Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlookup: pass and use MaxDelayedRows parameter #10489

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Oct 16, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam yumkam marked this pull request as ready for review October 16, 2024 09:48
@yumkam yumkam requested review from a team as code owners October 16, 2024 09:48
Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 09:50:45 UTC Pre-commit check linux-x86_64-release-asan for bb5d6a7 has started.
2024-10-16 09:51:17 UTC Artifacts will be uploaded here
2024-10-16 09:55:33 UTC ya make is running...
🔴 2024-10-16 10:59:43 UTC Build failed, see the logs.
🟢 2024-10-16 11:00:17 UTC ydbd size 5.7 GiB changed* by -792 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: fff7685 merge: bb5d6a7 diff diff %
ydbd size 6 099 867 936 Bytes 6 099 867 144 Bytes -792 Bytes -0.000%
ydbd stripped size 1 521 078 448 Bytes 1 521 074 480 Bytes -3.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 09:51:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for bb5d6a7 has started.
2024-10-16 09:51:45 UTC Artifacts will be uploaded here
2024-10-16 09:55:06 UTC ya make is running...
🔴 2024-10-16 10:48:09 UTC Build failed, see the logs.
🟢 2024-10-16 10:48:29 UTC ydbd size 2.8 GiB changed* by +37.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a4c9ddf merge: bb5d6a7 diff diff %
ydbd size 3 010 890 376 Bytes 3 010 928 304 Bytes +37.0 KiB +0.001%
ydbd stripped size 477 548 888 Bytes 477 556 632 Bytes +7.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam changed the title streamlookup: pass and use MaxDelay parameter streamlookup: pass and use MaxDelayedRows parameter Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 12:09:52 UTC Pre-commit check linux-x86_64-release-asan for 593d623 has started.
2024-10-16 12:09:56 UTC Artifacts will be uploaded here
2024-10-16 12:13:20 UTC ya make is running...
🟡 2024-10-16 14:24:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12781 12472 0 89 106 114

🟢 2024-10-16 14:25:23 UTC Build successful.
🟢 2024-10-16 14:25:58 UTC ydbd size 5.7 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 030f818 merge: 593d623 diff diff %
ydbd size 6 099 890 304 Bytes 6 099 894 792 Bytes +4.4 KiB +0.000%
ydbd stripped size 1 521 081 712 Bytes 1 521 082 352 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 12:12:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 593d623 has started.
2024-10-16 12:12:14 UTC Artifacts will be uploaded here
2024-10-16 12:15:49 UTC ya make is running...
🟡 2024-10-16 13:52:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75676 61701 0 5 13870 100

2024-10-16 13:59:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-16 14:11:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 6 0 0 1 98

🟢 2024-10-16 14:11:48 UTC Build successful.
🟢 2024-10-16 14:12:08 UTC ydbd size 2.8 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 030f818 merge: 593d623 diff diff %
ydbd size 3 010 928 160 Bytes 3 010 935 448 Bytes +7.1 KiB +0.000%
ydbd stripped size 477 553 432 Bytes 477 557 784 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam requested review from uzhastik and rvu1024 October 17, 2024 09:09
@yumkam yumkam merged commit f33f3fe into ydb-platform:main Oct 17, 2024
10 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Oct 18, 2024
yumkam added a commit that referenced this pull request Oct 18, 2024
…7892 #10280 (#10341)

Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com>
Co-authored-by: Hor911 <hor911@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants