Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24-3: schemeshard: fix crash on concurrent alter-extsubdomains #9201

Merged
merged 2 commits into from
Sep 13, 2024
Merged

24-3: schemeshard: fix crash on concurrent alter-extsubdomains #9201

merged 2 commits into from
Sep 13, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Sep 13, 2024 •
edited
Loading

merge 5c36245(#9157), ...(#9198) from main

KIKIMR-21965

  • enforce creation of TAlterExtSubDomain operations only through CreateCompatibleAlterExtSubDomain() to ensure all proper state checking
  • fix TAlterExtSubDomain compatibility with ESchemeOpAlterSubDomain

Changelog category

  • Not for changelog

ijon added 2 commits September 13, 2024 12:13
@ijon
schemeshard: make direct creation of TAlterExtSubDomain impossible (y…
4cce141 
…db-platform#9157)

KIKIMR-21965

Enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking.

### Changelog category

* Not for changelog
@ijon
schemeshard: fix AlterExtSubDomain compatibility with ESchemeOpAlterS…
aff948c 
…ubDomain

TAlterExtSubDomain suboperation should be able accept ESchemeOpAlterSubDomain
operation type.

This is special compatibility case for those old subdomains that
went through migration to a separate tenants at some time.
Console tablet holds records about types of the subdomains but they hadn't been
updated at the time of migration. So Console still thinks that old subdomains
are plain subdomains whereas they had been migrated to the extsubdomains.
And Console tablet is the main source of the subdomains alters.
This compatibility case should be upholded until Console records will be fixed.

KIKIMR-21965
@ijon ijon requested a review from a team as a code owner September 13, 2024 09:19
@ijon ijon mentioned this pull request Sep 13, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 09:22:45 UTC Pre-commit check for 784cc3a has started.
⚪ 2024-09-13 09:25:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-13 09:30:35 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 09:23:01 UTC Pre-commit check for 784cc3a has started.
⚪ 2024-09-13 09:25:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-13 10:07:24 UTC Build successful.
⚪ 2024-09-13 10:07:38 UTC Tests are running...
🔴 2024-09-13 11:30:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14225 12889 0 3 1301 32

🟢 2024-09-13 11:30:49 UTC ydbd size 8.2 GiB changed* by +9.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6302bdc merge: 784cc3a diff diff %
ydbd size 8 762 160 728 Bytes 8 762 170 824 Bytes +9.9 KiB +0.000%
ydbd stripped size 479 043 784 Bytes 479 043 784 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 09:23:18 UTC Pre-commit check for 784cc3a has started.
⚪ 2024-09-13 09:25:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-13 09:47:39 UTC Build successful.
⚪ 2024-09-13 09:47:58 UTC Tests are running...
🔴 2024-09-13 11:37:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9923 9859 0 6 25 33

🟢 2024-09-13 11:38:41 UTC ydbd size 5.5 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6302bdc merge: 784cc3a diff diff %
ydbd size 5 935 537 752 Bytes 5 935 546 040 Bytes +8.1 KiB +0.000%
ydbd stripped size 1 488 031 840 Bytes 1 488 033 376 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon linked an issue Sep 13, 2024 that may be closed by this pull request
schemeshard crash on concurrent alter-{ext,}subdomains #9204
Closed
@ijon ijon changed the title 24-3: schemeshard: fix crash on concurrent alter-extsubdomain 24-3: schemeshard: fix crash on concurrent alter-extsubdomainы Sep 13, 2024
@ijon ijon changed the title 24-3: schemeshard: fix crash on concurrent alter-extsubdomainы 24-3: schemeshard: fix crash on concurrent alter-extsubdomains Sep 13, 2024
@ijon ijon merged commit 1b9a283 into ydb-platform:stable-24-3 Sep 13, 2024
8 of 12 checks passed
@ijon ijon deleted the merge/24-3/fix-schemeshard-crash-on-alterexsubdomain branch September 13, 2024 12:19
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 25, 2024
@ijon @uzhastik
schemeshard: fix crash on concurrent alter-extsubdomains (ydb-platfor…
c4bfdeb 
…m#9201)
uzhastik added a commit that referenced this pull request Oct 25, 2024
@uzhastik @ijon
schemeshard: fix crash on concurrent alter-extsubdomains (#9201) (#10908
a6b5e7e 
)

Co-authored-by: ijon <ijon@ydb.tech>
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schemeshard crash on concurrent alter-{ext,}subdomains
2 participants
@ijon @fomichev3000