Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemeshard: make direct creation of TAlterExtSubDomain impossible #9157

Merged

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Sep 12, 2024

KIKIMR-21965

Enforce creation of TAlterExtSubDomain operations only through CreateCompatibleAlterExtSubDomain() to ensure all proper state checking.

Changelog category

  • Not for changelog

Copy link

github-actions bot commented Sep 12, 2024

2024-09-12 13:28:10 UTC Pre-commit check linux-x86_64-release-asan for dcd20e6 has started.
2024-09-12 13:28:51 UTC Artifacts will be uploaded here
2024-09-12 13:32:28 UTC ya make is running...
🔴 2024-09-12 15:40:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10384 10186 0 45 42 111

🟢 2024-09-12 15:40:59 UTC Build successful.
🟢 2024-09-12 15:41:36 UTC ydbd size 5.6 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e114110 merge: dcd20e6 diff diff %
ydbd size 6 049 501 288 Bytes 6 049 509 616 Bytes +8.1 KiB +0.000%
ydbd stripped size 1 513 832 688 Bytes 1 513 834 224 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 12, 2024

2024-09-12 13:55:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for dcd20e6 has started.
2024-09-12 13:55:39 UTC Artifacts will be uploaded here
2024-09-12 13:58:53 UTC ya make is running...
🟡 2024-09-12 15:12:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14989 13333 0 11 1365 280

2024-09-12 15:13:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-12 15:24:18 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
294 (only retried tests) 200 0 0 7 87

🟢 2024-09-12 15:24:28 UTC Build successful.
🟡 2024-09-12 15:25:05 UTC ydbd size 8.4 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 52e48f7 merge: dcd20e6 diff diff %
ydbd size 9 037 828 488 Bytes 9 039 153 192 Bytes +1.3 MiB +0.015%
ydbd stripped size 488 352 168 Bytes 488 463 080 Bytes +108.3 KiB +0.023%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 12, 2024

2024-09-12 13:55:58 UTC Pre-commit check linux-x86_64-release-clang14 for dcd20e6 has started.
2024-09-12 13:56:08 UTC Artifacts will be uploaded here
2024-09-12 13:58:50 UTC ya make is running...
🟢 2024-09-12 14:38:49 UTC Build successful.

@ijon ijon requested a review from CyberROFL September 12, 2024 15:34
@ijon ijon changed the title schemeshard: make creation of individual TAlterExtSubDomain impossible schemeshard: make direct creation of TAlterExtSubDomain impossible Sep 12, 2024
@ijon ijon requested a review from snaury September 12, 2024 15:51
@ijon ijon merged commit 5c36245 into ydb-platform:main Sep 12, 2024
14 of 16 checks passed
@ijon ijon deleted the fix-schemeshard-individual-alter-extsubdomain branch September 12, 2024 16:01
ijon added a commit to ijon/ydb that referenced this pull request Sep 13, 2024
…db-platform#9157)

KIKIMR-21965

Enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking.

### Changelog category

* Not for changelog
ijon added a commit to ijon/ydb that referenced this pull request Sep 13, 2024
…db-platform#9157)

KIKIMR-21965

Enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking.

### Changelog category

* Not for changelog
@ijon ijon linked an issue Sep 13, 2024 that may be closed by this pull request
ijon added a commit that referenced this pull request Sep 13, 2024
…ns (#9203)

merge 5c36245(#9157), ...(#9198) from `main`

KIKIMR-21965

- enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking
- fix `TAlterExtSubDomain` compatibility with ESchemeOpAlterSubDomain
ijon added a commit that referenced this pull request Sep 13, 2024
merge 5c36245(#9157), ...(#9198) from `main`

KIKIMR-21965

- enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking
- fix `TAlterExtSubDomain` compatibility with ESchemeOpAlterSubDomain
@shnikd shnikd mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schemeshard crash on concurrent alter-{ext,}subdomains
2 participants