Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditlog: add logouts #9050

Merged
merged 1 commit into from
Sep 11, 2024
Merged

auditlog: add logouts #9050

merged 1 commit into from
Sep 11, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Sep 11, 2024

Add audit logging for web logout operation.

Web logout now require proper authentication as audit record without name of the logged out user is meaningless. Previously web logout was anonymous.

KIKIMR-21764

Changelog entry

Add audit logging for web logout operation.

Changelog category

  • Improvement

Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 00:11:58 UTC Pre-commit check linux-x86_64-release-clang14 for 625213b has started.
2024-09-11 00:12:08 UTC Artifacts will be uploaded here
2024-09-11 00:14:56 UTC ya make is running...
🟢 2024-09-11 00:21:54 UTC Build successful.

Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 00:12:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 625213b has started.
2024-09-11 00:12:13 UTC Artifacts will be uploaded here
2024-09-11 00:15:02 UTC ya make is running...
🟡 2024-09-11 01:29:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74270 60390 0 2 13790 88

2024-09-11 01:36:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-11 01:43:47 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 16 0 0 0 83

🟢 2024-09-11 01:43:53 UTC Build successful.
🟡 2024-09-11 01:44:29 UTC ydbd size 8.4 GiB changed* by +166.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a8fb87e merge: 625213b diff diff %
ydbd size 9 026 603 144 Bytes 9 026 773 312 Bytes +166.2 KiB +0.002%
ydbd stripped size 487 764 200 Bytes 487 770 216 Bytes +5.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 00:12:18 UTC Pre-commit check linux-x86_64-release-asan for 625213b has started.
2024-09-11 00:12:29 UTC Artifacts will be uploaded here
2024-09-11 00:15:24 UTC ya make is running...
🔴 2024-09-11 01:53:34 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12004 11652 0 27 294 31

🟢 2024-09-11 01:54:37 UTC Build successful.
🟡 2024-09-11 01:55:11 UTC ydbd size 5.6 GiB changed* by +371.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 189aa4b merge: 625213b diff diff %
ydbd size 6 038 777 360 Bytes 6 039 158 056 Bytes +371.8 KiB +0.006%
ydbd stripped size 1 511 302 256 Bytes 1 511 375 856 Bytes +71.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Add audit logging for web logout operation.
Web logout now require proper authentication as audit record
without name of the logged out user is meaningless.
Previously web logout was anonymous.

KIKIMR-21764
@ijon ijon force-pushed the auditlog-add-logout branch from 1ea1662 to 3cc7b5c Compare September 11, 2024 06:56
Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 06:59:53 UTC Pre-commit check linux-x86_64-release-clang14 for d00c108 has started.
2024-09-11 07:00:03 UTC Artifacts will be uploaded here
2024-09-11 07:02:54 UTC ya make is running...
🟢 2024-09-11 07:09:26 UTC Build successful.

Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 07:00:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for d00c108 has started.
2024-09-11 07:00:10 UTC Artifacts will be uploaded here
2024-09-11 07:03:02 UTC ya make is running...
🟡 2024-09-11 08:21:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74276 60194 0 20 14036 26

2024-09-11 08:28:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-11 08:38:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
306 (only retried tests) 207 0 8 7 84

2024-09-11 08:38:52 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-11 08:45:41 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 15 0 0 0 82

🟢 2024-09-11 08:45:48 UTC Build successful.
🟡 2024-09-11 08:46:25 UTC ydbd size 8.4 GiB changed* by +166.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a8fb87e merge: d00c108 diff diff %
ydbd size 9 026 603 144 Bytes 9 026 773 312 Bytes +166.2 KiB +0.002%
ydbd stripped size 487 764 200 Bytes 487 770 216 Bytes +5.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 07:00:47 UTC Pre-commit check linux-x86_64-release-asan for d00c108 has started.
2024-09-11 07:00:57 UTC Artifacts will be uploaded here
2024-09-11 07:03:55 UTC ya make is running...
🔴 2024-09-11 08:59:41 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12013 11714 0 58 143 98

🟢 2024-09-11 09:00:42 UTC Build successful.
🟡 2024-09-11 09:01:19 UTC ydbd size 5.6 GiB changed* by +182.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a8fb87e merge: d00c108 diff diff %
ydbd size 6 038 971 496 Bytes 6 039 158 056 Bytes +182.2 KiB +0.003%
ydbd stripped size 1 511 346 800 Bytes 1 511 375 856 Bytes +28.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit ab1832e into ydb-platform:main Sep 11, 2024
10 of 12 checks passed
@ijon ijon deleted the auditlog-add-logout branch September 11, 2024 09:07
ijon added a commit that referenced this pull request Sep 11, 2024
Add audit logging for web logout operation.

merged ... (#9050) from main

Web logout now require proper authentication as audit record without name of the logged out user is meaningless. Previously web logout was anonymous.

KIKIMR-21764
ijon added a commit that referenced this pull request Sep 11, 2024
Add audit logging for web logout operation.

merged ... (#9050) from main

Web logout now require proper authentication as audit record without name of the logged out user is meaningless. Previously web logout was anonymous.

KIKIMR-21764
@shnikd shnikd mentioned this pull request Sep 11, 2024
zinal pushed a commit to zinal/ydb that referenced this pull request Oct 21, 2024
Add audit logging for web logout operation.

merged ... (ydb-platform#9050) from main

Web logout now require proper authentication as audit record without name of the logged out user is meaningless. Previously web logout was anonymous.

KIKIMR-21764
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 7, 2024
Add audit logging for web logout operation.

merged ... (ydb-platform#9050) from main

Web logout now require proper authentication as audit record without name of the logged out user is meaningless. Previously web logout was anonymous.

KIKIMR-21764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants