Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-3671 move ydb/core/formats into ydb/library/formats #9180

Merged
merged 6 commits into from
Sep 13, 2024
Merged

YQ-3671 move ydb/core/formats into ydb/library/formats #9180

merged 6 commits into from
Sep 13, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Sep 12, 2024 •
edited
Loading

Changelog entry

Moved ydb/core/formats into ydb/library/formats, except of:

  • ydb/core/formats/arrow/serializer
  • ydb/core/formats/arrow/dictionary

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

In ydb/core/formats there are only files and functions that depend on:

  • ydb/core/formats/arrow/serializer
  • ydb/core/formats/arrow/dictionary
  • ydb/core/scheme_types
  • ydb/core/scheme

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner September 12, 2024 19:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 19:43:21 UTC Pre-commit check linux-x86_64-release-clang14 for 05fe25c has started.
⚪ 2024-09-12 19:43:30 UTC Artifacts will be uploaded here
🔴 2024-09-12 19:45:15 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 19:43:42 UTC Pre-commit check linux-x86_64-release-asan for 05fe25c has started.
⚪ 2024-09-12 19:43:52 UTC Artifacts will be uploaded here
🔴 2024-09-12 19:45:43 UTC Graph compare failed, see the logs.
⚫ 2024-09-12 19:45:48 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 19:43:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 05fe25c has started.
⚪ 2024-09-12 19:43:52 UTC Artifacts will be uploaded here
⚫ 2024-09-12 19:45:51 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 19:47:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1968ec4 has started.
⚪ 2024-09-12 19:47:17 UTC Artifacts will be uploaded here
🔴 2024-09-12 19:49:11 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 19:49:05 UTC Pre-commit check linux-x86_64-release-clang14 for 1968ec4 has started.
⚪ 2024-09-12 19:49:15 UTC Artifacts will be uploaded here
🔴 2024-09-12 19:51:05 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 19:49:35 UTC Pre-commit check linux-x86_64-release-asan for 1968ec4 has started.
⚪ 2024-09-12 19:49:45 UTC Artifacts will be uploaded here
🔴 2024-09-12 19:51:35 UTC Graph compare failed, see the logs.

@GrigoriyPA GrigoriyPA requested a review from vitstn September 12, 2024 19:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 20:19:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 40e32d6 has started.
⚪ 2024-09-12 20:20:06 UTC Artifacts will be uploaded here
🔴 2024-09-12 20:21:57 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 20:20:03 UTC Pre-commit check linux-x86_64-release-clang14 for 40e32d6 has started.
⚪ 2024-09-12 20:20:13 UTC Artifacts will be uploaded here
🔴 2024-09-12 20:22:02 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 20:20:04 UTC Pre-commit check linux-x86_64-release-asan for 40e32d6 has started.
⚪ 2024-09-12 20:20:14 UTC Artifacts will be uploaded here
🔴 2024-09-12 20:22:02 UTC Graph compare failed, see the logs.

@GrigoriyPA GrigoriyPA force-pushed the YQ-3671-move-arrow-size-calcer-into-yql-library branch from 2e81bbe to 9b3003e Compare September 12, 2024 20:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 20:28:01 UTC Pre-commit check linux-x86_64-release-clang14 for 22a60c5 has started.
⚪ 2024-09-12 20:28:09 UTC Artifacts will be uploaded here
⚪ 2024-09-12 20:31:16 UTC ya make is running...
🔴 2024-09-12 20:49:40 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 20:28:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 22a60c5 has started.
⚪ 2024-09-12 20:28:13 UTC Artifacts will be uploaded here
⚪ 2024-09-12 20:31:21 UTC ya make is running...
🔴 2024-09-12 20:35:19 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 20:28:10 UTC Pre-commit check linux-x86_64-release-asan for 22a60c5 has started.
⚪ 2024-09-12 20:28:19 UTC Artifacts will be uploaded here
⚪ 2024-09-12 20:31:29 UTC ya make is running...
🔴 2024-09-12 20:41:25 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 21:14:42 UTC Pre-commit check linux-x86_64-release-asan for 0eedd82 has started.
⚪ 2024-09-12 21:14:53 UTC Artifacts will be uploaded here
⚪ 2024-09-12 21:18:04 UTC ya make is running...
🔴 2024-09-12 23:20:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11824 11664 0 23 39 98

🟢 2024-09-12 23:21:27 UTC Build successful.
🟡 2024-09-12 23:22:00 UTC ydbd size 5.6 GiB changed* by +323.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e3b7f65 merge: 0eedd82 diff diff %
ydbd size 6 051 289 856 Bytes 6 051 620 960 Bytes +323.3 KiB +0.005%
ydbd stripped size 1 514 262 544 Bytes 1 514 270 416 Bytes +7.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 21:14:43 UTC Pre-commit check linux-x86_64-release-clang14 for 0eedd82 has started.
⚪ 2024-09-12 21:14:52 UTC Artifacts will be uploaded here
⚪ 2024-09-12 21:18:11 UTC ya make is running...
🟢 2024-09-12 21:49:17 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 21:16:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0eedd82 has started.
⚪ 2024-09-12 21:16:47 UTC Artifacts will be uploaded here
⚪ 2024-09-12 21:20:05 UTC ya make is running...
🟡 2024-09-12 23:05:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41156 35442 0 4 5677 33

⚪ 2024-09-12 23:08:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-12 23:19:04 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 (only retried tests) 189 0 0 7 85

🟢 2024-09-12 23:19:12 UTC Build successful.
🟡 2024-09-12 23:19:53 UTC ydbd size 8.4 GiB changed* by +892.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e3b7f65 merge: 0eedd82 diff diff %
ydbd size 9 041 615 464 Bytes 9 042 529 656 Bytes +892.8 KiB +0.010%
ydbd stripped size 488 595 144 Bytes 488 595 016 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 51f5000 into ydb-platform:main Sep 13, 2024
10 of 12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3671-move-arrow-size-calcer-into-yql-library branch September 13, 2024 10:42
This was referenced Sep 13, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 17, 2024
@GrigoriyPA @zverevgeny
YQ-3671 move ydb/core/formats into ydb/library/formats (ydb-platform#…
69a5f4f 
…9180)

Conflicts:
	ydb/core/formats/arrow/common/container.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/checker.cpp
	ydb/core/tx/columnshard/engines/storage/indexes/count_min_sketch/meta.cpp
This was referenced Sep 18, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

@ivanmorozov333 ivanmorozov333 Awaiting requested review from ivanmorozov333

@vitstn vitstn Awaiting requested review from vitstn

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriyPA @zverevgeny