do not treat initial tablet metrics values as 0 #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
adameat
approved these changes
May 8, 2024
This was referenced May 8, 2024
This was referenced May 16, 2024
MrLolthe1st
pushed a commit
to MrLolthe1st/ydb
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
fix a case where tablet metrics were not updated
Changelog category
Additional information
A tablet assumes that initial value for any metric is 0, and if the value does not change much from 0 it does not need to be reported. This is incorrect, because the value in Hive might be different from 0 - because of initialization with average metrics, or because of metrics from the previous generation.