do not treat initial tablet metrics values as 0 (ydb-platform#4355)

MrLolthe1st · May 28, 2024 · f99b1c2 · f99b1c2
1 parent 2906312
commit f99b1c2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/ydb/core/tablet/tablet_metrics.cpp b/ydb/core/tablet/tablet_metrics.cpp
@@ -107,9 +107,9 @@ namespace {
             if (value.IsValueReady()) {
                 auto val = !value.IsValueObsolete(now) ? value.GetValue() : 0;
                 ui32 levelVal = val / significantChange;
-                auto& lit = levels[groupId];
-                if (lit != levelVal || force) {
-                    lit = levelVal;
+                auto [lit, inserted] = levels.insert({groupId, 0});
+                if (inserted || lit->second != levelVal || force) {
+                    lit->second = levelVal;
                     haveChanges = true;
                     // N.B. keep going so all levels are properly updated
                 }

diff --git a/ydb/core/tablet/tablet_metrics.h b/ydb/core/tablet/tablet_metrics.h
@@ -69,11 +69,11 @@ class TResourceMetricsSendState {
     const ui64 TabletId;
     const ui32 FollowerId;
     const TActorId Launcher;
-    ui32 LevelCPU = 0;
-    ui32 LevelMemory = 0;
-    ui32 LevelNetwork = 0;
-    ui32 LevelStorage = 0;
-    ui32 LevelIops = 0;
+    std::optional<ui32> LevelCPU;
+    std::optional<ui32> LevelMemory;
+    std::optional<ui32> LevelNetwork;
+    std::optional<ui32> LevelStorage;
+    std::optional<ui32> LevelIops;
     THashMap<std::pair<TChannel, TGroupId>, ui32> LevelReadThroughput;
     THashMap<std::pair<TChannel, TGroupId>, ui32> LevelWriteThroughput;
     THashMap<std::pair<TChannel, TGroupId>, ui32> LevelReadIops;