Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move construction of current compatibility information out of driver_lib #2480

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Move construction of current compatibility information out of driver_lib #2480

merged 2 commits into from
Mar 11, 2024

Conversation

serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Mar 6, 2024 •
edited
Loading

...

@serbel324 serbel324 force-pushed the bs/version/separate-current-compatibility branch from 5dcbfe8 to 29b93f4 Compare March 6, 2024 09:10
@serbel324 serbel324 force-pushed the bs/version/separate-current-compatibility branch from 29b93f4 to 106c34d Compare March 6, 2024 09:10
@serbel324 serbel324 changed the title Move contstruction of current compatibility information out of driver_lib Move construction of current compatibility information out of driver_lib Mar 6, 2024
@serbel324 serbel324 linked an issue Mar 6, 2024 that may be closed by this pull request
Set current CompatibilityInfo outside of driver_lib #2478
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 09:12:20 UTC Pre-commit check for 68d8da2 has started.
⚪ 2024-03-06 09:12:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 09:16:05 UTC Build successful.
⚪ 2024-03-06 09:16:19 UTC Tests are running...
🔴 2024-03-06 11:13:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67546 56582 0 25 10914 25

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 09:14:39 UTC Pre-commit check for 68d8da2 has started.
⚪ 2024-03-06 09:14:42 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 09:24:05 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 09:14:47 UTC Pre-commit check for 68d8da2 has started.
⚪ 2024-03-06 09:14:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 09:18:24 UTC Build successful.
⚪ 2024-03-06 09:18:37 UTC Tests are running...
🔴 2024-03-06 11:01:55 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14463 14271 0 45 117 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 13:42:08 UTC Pre-commit check for fa202e9 has started.
⚪ 2024-03-06 13:42:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 13:47:41 UTC Build successful.
⚪ 2024-03-06 13:47:51 UTC Tests are running...
🔴 2024-03-06 13:54:48 UTC Test run completed, no test results found for commit 45d11ae. Please check build logs.
⚫ 2024-03-06 13:54:51 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 13:51:32 UTC Pre-commit check for fa202e9 has started.
⚪ 2024-03-06 13:51:33 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-06 13:54:46 UTC Check cancelled

@serbel324 serbel324 force-pushed the bs/version/separate-current-compatibility branch from 45d11ae to f0f352a Compare March 6, 2024 13:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 13:56:52 UTC Pre-commit check for ea54d72 has started.
⚪ 2024-03-06 13:56:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 13:58:27 UTC Build successful.
⚪ 2024-03-06 13:58:35 UTC Tests are running...
🔴 2024-03-06 14:01:19 UTC Test run completed, no test results found for commit f0f352a. Please check build logs.
⚫ 2024-03-06 14:01:22 UTC Check cancelled

@serbel324 serbel324 force-pushed the bs/version/separate-current-compatibility branch from f0f352a to dcd9a7e Compare March 6, 2024 14:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 14:05:34 UTC Pre-commit check for b0e0c6d has started.
⚪ 2024-03-06 14:05:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 14:08:46 UTC Build successful.
⚪ 2024-03-06 14:08:58 UTC Tests are running...
🔴 2024-03-06 14:12:43 UTC Test run completed, no test results found for commit dcd9a7e. Please check build logs.
⚫ 2024-03-06 14:12:47 UTC Check cancelled

@serbel324 serbel324 force-pushed the bs/version/separate-current-compatibility branch from dcd9a7e to 1590a5f Compare March 6, 2024 14:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 14:47:25 UTC Pre-commit check for 7f90ca5 has started.
⚪ 2024-03-06 14:47:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 14:48:58 UTC Build successful.
⚪ 2024-03-06 14:49:08 UTC Tests are running...
🔴 2024-03-06 15:51:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65685 54724 0 44 10897 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 14:57:26 UTC Pre-commit check for 7f90ca5 has started.
⚪ 2024-03-06 14:57:28 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 15:00:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 15:36:18 UTC Pre-commit check for 7f90ca5 has started.
⚪ 2024-03-06 15:36:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 15:39:04 UTC Build successful.
⚪ 2024-03-06 15:39:15 UTC Tests are running...
🔴 2024-03-06 16:24:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12485 12337 0 64 61 23

@serbel324 serbel324 force-pushed the bs/version/separate-current-compatibility branch from 1590a5f to f5aca09 Compare March 6, 2024 21:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 21:27:07 UTC Pre-commit check for 575ad55 has started.
⚪ 2024-03-06 21:27:09 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 21:30:59 UTC Build successful.
⚪ 2024-03-06 21:31:13 UTC Tests are running...
🟢 2024-03-06 23:02:43 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68249 57306 0 0 10918 25

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 21:27:08 UTC Pre-commit check for 575ad55 has started.
⚪ 2024-03-06 21:27:10 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 21:31:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

⚪ 2024-03-06 21:27:17 UTC Pre-commit check for 575ad55 has started.
⚪ 2024-03-06 21:27:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 21:31:22 UTC Build successful.
⚪ 2024-03-06 21:31:35 UTC Tests are running...
🔴 2024-03-06 23:10:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14949 14800 0 26 92 31

alexvru
alexvru reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@alexvru alexvru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me.

@serbel324 serbel324 merged commit 6ec1e11 into ydb-platform:main Mar 11, 2024
5 of 6 checks passed
serbel324 added a commit to serbel324/ydb that referenced this pull request Mar 11, 2024
@serbel324
Move construction of current compatibility information out of driver_…
50d351b 
…lib (ydb-platform#2480)
serbel324 added a commit to serbel324/ydb that referenced this pull request Mar 11, 2024
@serbel324
Move construction of current compatibility information out of driver_…
f111064 
…lib (ydb-platform#2480)
serbel324 added a commit to serbel324/ydb that referenced this pull request Mar 11, 2024
@serbel324
Move construction of current compatibility information out of driver_…
e6d7d8b 
…lib (ydb-platform#2480)
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 19, 2024
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
This was referenced Apr 6, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru alexvru left review comments

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set current CompatibilityInfo outside of driver_lib
3 participants
@serbel324 @fomichev3000 @alexvru