Merge f0f352a into 96c9390

ydb-platform · Mar 6, 2024 · ea54d72 · ea54d72
2 parents 96c9390 + f0f352a
commit ea54d72
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 5 deletions.
diff --git a/ydb/apps/version/version_definition.cpp b/ydb/apps/version/version_definition.cpp
@@ -0,0 +1,11 @@
+#include <ydb/core/driver_lib/version/version.h>
+
+NKikimrConfig::TCurrentCompatibilityInfo NKikimr::TCompatibilityInfo::MakeCurrent() {
+    using TCurrentConstructor = NKikimr::TCompatibilityInfo::TProtoConstructor::TCurrentCompatibilityInfo;
+    // using TVersionConstructor = NKikimr::TCompatibilityInfo::TProtoConstructor::TVersion;
+    // using TCompatibilityRuleConstructor = NKikimr::TCompatibilityInfo::TProtoConstructor::TCompatibilityRule;
+
+    return TCurrentConstructor{
+        .Application = "ydb",
+    }.ToPB();
+}
diff --git a/ydb/apps/version/ya.make b/ydb/apps/version/ya.make
@@ -0,0 +1,11 @@
+LIBRARY(version_definition)
+
+SRCS(
+    version_definition.cpp
+)
+
+PEERDIR(
+    ydb/core/driver_lib/version
+)
+
+END()
diff --git a/ydb/core/driver_lib/version/version.cpp b/ydb/core/driver_lib/version/version.cpp
@@ -17,18 +17,14 @@ using EComponentId = NKikimrConfig::TCompatibilityRule;
 using TComponentId = NKikimrConfig::TCompatibilityRule::EComponentId;
 
 TCompatibilityInfo::TCompatibilityInfo() {
-    using TCurrentConstructor = TCompatibilityInfo::TProtoConstructor::TCurrentCompatibilityInfo;
     using TStoredConstructor = TCompatibilityInfo::TProtoConstructor::TStoredCompatibilityInfo;
-    // using TCompatibilityRuleConstructor = TCompatibilityInfo::TProtoConstructor::TCompatibilityRule;
     using TVersionConstructor = TCompatibilityInfo::TProtoConstructor::TVersion;
 
     /////////////////////////////////////////////////////////
     // Current CompatibilityInfo
     /////////////////////////////////////////////////////////
 
-    auto current = TCurrentConstructor{
-        .Application = "ydb"
-    }.ToPB();
+    auto current = MakeCurrent();
 
     // bool success = CompleteFromTag(current);
     // Y_ABORT_UNLESS(success);

diff --git a/ydb/core/driver_lib/version/version.h b/ydb/core/driver_lib/version/version.h
@@ -141,6 +141,8 @@ class TCompatibilityInfo {
 
     bool CompleteFromTag(NKikimrConfig::TCurrentCompatibilityInfo& current);
 
+    static NKikimrConfig::TCurrentCompatibilityInfo MakeCurrent();
+
     NKikimrConfig::TStoredCompatibilityInfo MakeStored(TComponentId componentId) const;
     NKikimrConfig::TStoredCompatibilityInfo MakeStored(TComponentId componentId,
             const NKikimrConfig::TCurrentCompatibilityInfo* current) const;

diff --git a/ydb/core/mind/bscontroller/ut_selfheal/ya.make b/ydb/core/mind/bscontroller/ut_selfheal/ya.make
@@ -16,6 +16,7 @@ SRCS(
 )
 
 PEERDIR(
+    ydb/apps/version
     ydb/core/blobstorage/dsproxy/mock
     ydb/core/blobstorage/pdisk/mock
     ydb/core/mind/bscontroller