Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable log batching for kv tablet #2263

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Disable log batching for kv tablet #2263

merged 2 commits into from
Feb 28, 2024

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Feb 27, 2024

Changelog entry

...

Changelog category

  • Performance improvement

Additional information

...

@kruall kruall requested a review from alexvru February 27, 2024 10:51
@kruall kruall self-assigned this Feb 27, 2024
@kruall kruall linked an issue Feb 27, 2024 that may be closed by this pull request
Understand why in tests using the kv tablet there is no response recording #2266
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 11:35:32 UTC Pre-commit check for db4e867 has started.
⚪ 2024-02-27 11:35:33 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-27 12:09:50 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 11:56:35 UTC Pre-commit check for db4e867 has started.
⚪ 2024-02-27 11:56:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-27 12:34:49 UTC Build successful.
⚪ 2024-02-27 12:34:58 UTC Tests are running...
🔴 2024-02-27 14:14:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14858 14707 0 36 92 23

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 12:17:17 UTC Pre-commit check for db4e867 has started.
⚪ 2024-02-27 12:17:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-27 12:54:12 UTC Build successful.
⚪ 2024-02-27 12:54:24 UTC Tests are running...
🔴 2024-02-27 14:27:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67973 57056 0 10 10883 24

@kruall kruall merged commit 54e51e8 into ydb-platform:main Feb 28, 2024
3 of 5 checks passed
@kruall kruall deleted the kv/disbale_log_batching branch February 28, 2024 04:45
kruall added a commit that referenced this pull request Feb 28, 2024
@kruall
Revert "Disable log batching for kv tablet (#2263)"
4da5283 
This reverts commit 54e51e8.
@kruall kruall mentioned this pull request Feb 28, 2024
Merged
@serbel324 serbel324 mentioned this pull request Mar 1, 2024
Merged
This was referenced Mar 4, 2024
Closed
Merged
This was referenced Mar 6, 2024
Merged
Open
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 7, 2024
Merged
This was referenced Mar 8, 2024
Merged
Closed
This was referenced Mar 11, 2024
Merged
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
@shnikd shnikd mentioned this pull request Mar 25, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru

Assignees

@kruall kruall

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Understand why in tests using the kv tablet there is no response recording
2 participants
@kruall @alexvru