Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underflows in TValueHistory::Accumulate #14442

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Feb 11, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kruall kruall added the area/actorsystem Actor System related issues label Feb 11, 2025
@kruall kruall requested a review from alexvru February 11, 2025 13:34
@kruall kruall changed the title Fix underflow with seconds=0 and withTail=false Fix underflows in TValueHistory::Accumulate Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 13:38:17 UTC Pre-commit check linux-x86_64-release-asan for 78293c2 has started.
2025-02-11 13:38:29 UTC Artifacts will be uploaded here
2025-02-11 13:41:34 UTC ya make is running...
🔴 2025-02-11 13:43:43 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 13:38:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 78293c2 has started.
2025-02-11 13:38:45 UTC Artifacts will be uploaded here
2025-02-11 13:41:36 UTC ya make is running...
🔴 2025-02-11 13:43:39 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 14:01:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for c2130c6 has started.
2025-02-11 14:01:38 UTC Artifacts will be uploaded here
2025-02-11 14:04:38 UTC ya make is running...
🟡 2025-02-11 15:01:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27660 24906 0 4 2675 75

2025-02-11 15:04:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-11 15:15:43 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
382 (only retried tests) 252 0 0 7 123

🟢 2025-02-11 15:15:52 UTC Build successful.
🟢 2025-02-11 15:16:11 UTC ydbd size 2.1 GiB changed* by -4.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8b46b94 merge: c2130c6 diff diff %
ydbd size 2 228 845 040 Bytes 2 228 840 768 Bytes -4.2 KiB -0.000%
ydbd stripped size 473 239 000 Bytes 473 234 904 Bytes -4.0 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 14:02:25 UTC Pre-commit check linux-x86_64-release-asan for c2130c6 has started.
2025-02-11 14:02:30 UTC Artifacts will be uploaded here
2025-02-11 14:05:29 UTC ya make is running...
🟡 2025-02-11 15:21:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13367 13298 0 17 14 38

2025-02-11 15:23:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-11 15:35:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 60 0 0 7 35

🟢 2025-02-11 15:35:37 UTC Build successful.
🟢 2025-02-11 15:36:02 UTC ydbd size 3.6 GiB changed* by -3.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8b46b94 merge: c2130c6 diff diff %
ydbd size 3 876 010 832 Bytes 3 876 007 616 Bytes -3.1 KiB -0.000%
ydbd stripped size 1 357 290 928 Bytes 1 357 286 768 Bytes -4.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall merged commit a61d156 into ydb-platform:main Feb 11, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/actorsystem Actor System related issues not-for-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants