Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ remove anonymous namespace from CA #14636

Merged

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Feb 17, 2025

Changelog entry

Removed anonymous namespace from CA

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 10:40:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 303e36a has started.
2025-02-17 10:43:37 UTC Check cancelled

Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 10:47:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0395806 has started.
2025-02-17 10:47:49 UTC Artifacts will be uploaded here
2025-02-17 10:50:37 UTC ya make is running...
2025-02-17 11:05:11 UTC Check cancelled

Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 10:47:54 UTC Pre-commit check linux-x86_64-release-asan for 0395806 has started.
2025-02-17 11:05:03 UTC Check cancelled

uzhastik
uzhastik previously approved these changes Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 11:10:01 UTC Pre-commit check linux-x86_64-release-asan for 74b794f has started.
2025-02-17 11:10:13 UTC Artifacts will be uploaded here
2025-02-17 11:13:01 UTC ya make is running...
🟡 2025-02-17 12:15:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11951 11880 0 22 12 37

2025-02-17 12:17:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 12:29:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
110 (only retried tests) 71 0 2 4 33

2025-02-17 12:29:42 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-17 12:47:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 34 0 0 2 32

🟢 2025-02-17 12:47:40 UTC Build successful.
🟢 2025-02-17 12:48:11 UTC ydbd size 3.6 GiB changed* by +19.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ae6b4e2 merge: 74b794f diff diff %
ydbd size 3 889 526 368 Bytes 3 889 545 992 Bytes +19.2 KiB +0.001%
ydbd stripped size 1 361 456 656 Bytes 1 361 466 736 Bytes +9.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from uzhastik February 17, 2025 11:10
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 11:19:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 74b794f has started.
2025-02-17 11:20:04 UTC Artifacts will be uploaded here
2025-02-17 11:22:51 UTC ya make is running...
🟢 2025-02-17 12:20:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26125 23524 0 0 2457 144

🟢 2025-02-17 12:23:42 UTC Build successful.
🟢 2025-02-17 12:23:58 UTC ydbd size 2.1 GiB changed* by +9.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ae6b4e2 merge: 74b794f diff diff %
ydbd size 2 235 997 016 Bytes 2 236 006 720 Bytes +9.5 KiB +0.000%
ydbd stripped size 473 775 704 Bytes 473 776 024 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested review from vitstn and nikvas0 February 17, 2025 13:48
@GrigoriyPA GrigoriyPA merged commit 609889d into ydb-platform:main Feb 17, 2025
12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-remove-anonymous-namespace-from-CA branch February 17, 2025 13:55
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants