Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yt provider] Fix column group calculation for YtCopy #11435

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

rvu1024
Copy link
Member

@rvu1024 rvu1024 commented Nov 9, 2024

Changelog entry

Enforce equal groups in YtCopy and leading operation

Changelog category

  • Bugfix

Additional information

...

@rvu1024 rvu1024 added the area/yql YQL query language issues label Nov 9, 2024
@rvu1024 rvu1024 requested a review from a team as a code owner November 9, 2024 14:25
@github-actions github-actions bot added the bugfix label Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

2024-11-09 14:29:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for ca50957 has started.
2024-11-09 14:29:36 UTC Artifacts will be uploaded here
2024-11-09 14:32:38 UTC ya make is running...
🟡 2024-11-09 15:31:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74196 60101 0 1 13990 104

2024-11-09 15:38:33 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-09 15:50:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 9 0 0 0 95

🟢 2024-11-09 15:50:13 UTC Build successful.
🟢 2024-11-09 15:50:32 UTC ydbd size 2.8 GiB changed* by +57.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 302fd2e merge: ca50957 diff diff %
ydbd size 3 046 777 704 Bytes 3 046 836 800 Bytes +57.7 KiB +0.002%
ydbd stripped size 482 227 800 Bytes 482 231 768 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 9, 2024

2024-11-09 14:30:51 UTC Pre-commit check linux-x86_64-release-asan for ca50957 has started.
2024-11-09 14:31:01 UTC Artifacts will be uploaded here
2024-11-09 14:34:05 UTC ya make is running...
🟡 2024-11-09 15:41:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9551 9471 0 26 21 33

🟢 2024-11-09 15:42:38 UTC Build successful.
🟡 2024-11-09 15:43:08 UTC ydbd size 5.7 GiB changed* by +110.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 302fd2e merge: ca50957 diff diff %
ydbd size 6 165 941 768 Bytes 6 166 054 920 Bytes +110.5 KiB +0.002%
ydbd stripped size 1 537 509 200 Bytes 1 537 523 344 Bytes +13.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rvu1024 rvu1024 requested a review from nepal November 9, 2024 14:44
@rvu1024 rvu1024 enabled auto-merge (squash) November 9, 2024 16:35
@rvu1024 rvu1024 merged commit a7178b2 into ydb-platform:main Nov 10, 2024
11 checks passed
@rvu1024 rvu1024 deleted the fix_col_groups branch November 11, 2024 10:13
rvu1024 added a commit to rvu1024/ydb that referenced this pull request Nov 14, 2024
@rvu1024 rvu1024 mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants