Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ RD enable LLVM in purecalc filters #11442

Merged
merged 8 commits into from
Nov 13, 2024
Merged

YQ RD enable LLVM in purecalc filters #11442

merged 8 commits into from
Nov 13, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Nov 10, 2024 •
edited
Loading

Changelog entry

Enabled LLVM in purecalc filters

Changelog category

  • Performance improvement

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner November 10, 2024 15:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

⚪ 2024-11-10 15:28:32 UTC Pre-commit check linux-x86_64-release-asan for c4adfa3 has started.
⚪ 2024-11-10 15:28:44 UTC Artifacts will be uploaded here
⚪ 2024-11-10 15:31:48 UTC ya make is running...
⚫ 2024-11-10 15:45:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

⚪ 2024-11-10 15:30:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for c4adfa3 has started.
⚪ 2024-11-10 15:31:04 UTC Artifacts will be uploaded here
⚪ 2024-11-10 15:34:06 UTC ya make is running...
⚫ 2024-11-10 15:45:41 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

⚪ 2024-11-10 15:46:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5f17110 has started.
⚪ 2024-11-10 15:46:26 UTC Artifacts will be uploaded here
⚪ 2024-11-10 15:49:24 UTC ya make is running...
🟡 2024-11-10 16:41:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39966 34306 0 2 5558 100

⚪ 2024-11-10 16:44:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-10 16:55:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 5 0 0 1 96

🟢 2024-11-10 16:55:41 UTC Build successful.
🟢 2024-11-10 16:55:59 UTC ydbd size 2.8 GiB changed* by +304 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: a27ab2e merge: 5f17110 diff diff %
ydbd size 3 046 836 792 Bytes 3 046 837 096 Bytes +304 Bytes +0.000%
ydbd stripped size 482 232 088 Bytes 482 232 152 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

⚪ 2024-11-10 15:49:48 UTC Pre-commit check linux-x86_64-release-asan for 5f17110 has started.
⚪ 2024-11-10 15:49:59 UTC Artifacts will be uploaded here
⚪ 2024-11-10 15:52:59 UTC ya make is running...
🟡 2024-11-10 16:55:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8811 8743 0 25 10 33

🟢 2024-11-10 16:56:19 UTC Build successful.
🟢 2024-11-10 16:56:50 UTC ydbd size 5.7 GiB changed* by +416 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: a27ab2e merge: 5f17110 diff diff %
ydbd size 6 166 048 240 Bytes 6 166 048 656 Bytes +416 Bytes +0.000%
ydbd stripped size 1 537 522 960 Bytes 1 537 523 088 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 08:33:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7552639 has started.
⚪ 2024-11-12 08:33:53 UTC Artifacts will be uploaded here
⚪ 2024-11-12 08:37:08 UTC ya make is running...
⚫ 2024-11-12 08:43:36 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 08:33:47 UTC Pre-commit check linux-x86_64-release-asan for 7552639 has started.
⚪ 2024-11-12 08:33:58 UTC Artifacts will be uploaded here
⚪ 2024-11-12 08:36:59 UTC ya make is running...
⚫ 2024-11-12 08:43:34 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 08:44:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6246049 has started.
⚪ 2024-11-12 08:45:17 UTC Artifacts will be uploaded here
⚪ 2024-11-12 08:49:27 UTC ya make is running...
⚫ 2024-11-12 09:13:41 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 08:47:37 UTC Pre-commit check linux-x86_64-release-asan for 6246049 has started.
⚪ 2024-11-12 08:47:47 UTC Artifacts will be uploaded here
⚪ 2024-11-12 08:50:49 UTC ya make is running...
⚫ 2024-11-12 09:13:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 09:15:18 UTC Pre-commit check linux-x86_64-release-asan for 90e29e0 has started.
⚪ 2024-11-12 09:15:29 UTC Artifacts will be uploaded here
⚪ 2024-11-12 09:18:30 UTC ya make is running...
🟡 2024-11-12 10:27:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9076 8986 0 35 9 46

🟢 2024-11-12 10:28:00 UTC Build successful.
🟡 2024-11-12 10:28:31 UTC ydbd size 5.7 GiB changed* by +511.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5f2bf90 merge: 90e29e0 diff diff %
ydbd size 6 172 168 688 Bytes 6 172 691 936 Bytes +511.0 KiB +0.008%
ydbd stripped size 1 538 355 344 Bytes 1 538 461 424 Bytes +103.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 09:16:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 90e29e0 has started.
⚪ 2024-11-12 09:16:23 UTC Artifacts will be uploaded here
⚪ 2024-11-12 09:19:25 UTC ya make is running...
🟡 2024-11-12 10:18:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40410 34730 0 9 5558 113

⚪ 2024-11-12 10:22:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-12 10:34:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 8 0 1 0 108

⚪ 2024-11-12 10:34:27 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-12 10:45:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 0 0 1 0 108

🟢 2024-11-12 10:45:53 UTC Build successful.
🟡 2024-11-12 10:46:15 UTC ydbd size 2.8 GiB changed* by +236.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5f2bf90 merge: 90e29e0 diff diff %
ydbd size 3 049 982 432 Bytes 3 050 224 496 Bytes +236.4 KiB +0.008%
ydbd stripped size 482 438 360 Bytes 482 471 992 Bytes +32.8 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from uzhastik November 12, 2024 09:28
@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Nov 12, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 11:39:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f39b08 has started.
⚪ 2024-11-12 11:39:17 UTC Artifacts will be uploaded here
⚪ 2024-11-12 11:42:18 UTC ya make is running...
🟡 2024-11-12 12:37:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40412 34723 0 15 5558 116

⚪ 2024-11-12 12:41:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 12:53:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 13 0 0 0 110

🟢 2024-11-12 12:53:27 UTC Build successful.
🟢 2024-11-12 12:53:47 UTC ydbd size 2.8 GiB changed* by +53.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a2e65ee merge: 3f39b08 diff diff %
ydbd size 3 049 941 624 Bytes 3 049 995 960 Bytes +53.1 KiB +0.002%
ydbd stripped size 482 445 048 Bytes 482 453 304 Bytes +8.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 11:39:35 UTC Pre-commit check linux-x86_64-release-asan for 3f39b08 has started.
⚪ 2024-11-12 11:40:19 UTC Artifacts will be uploaded here
⚪ 2024-11-12 11:44:18 UTC ya make is running...
🟡 2024-11-12 12:53:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9079 8971 0 49 12 47

🟢 2024-11-12 12:54:45 UTC Build successful.
🟢 2024-11-12 12:55:19 UTC ydbd size 5.7 GiB changed* by +55.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a431c94 merge: 3f39b08 diff diff %
ydbd size 6 172 119 184 Bytes 6 172 175 872 Bytes +55.4 KiB +0.001%
ydbd stripped size 1 538 319 920 Bytes 1 538 329 968 Bytes +9.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

kardymonds
kardymonds previously approved these changes Nov 13, 2024
View reviewed changes
@GrigoriyPA GrigoriyPA force-pushed the YQ-RD-enable-LLVM-in-purecalc-filters branch from bdb83cd to 04543d6 Compare November 13, 2024 13:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:14:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for d5d74eb has started.
⚪ 2024-11-13 13:14:51 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:17:48 UTC ya make is running...
🔴 2024-11-13 13:21:14 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:16:06 UTC Pre-commit check linux-x86_64-release-asan for d5d74eb has started.
⚪ 2024-11-13 13:16:17 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:19:14 UTC ya make is running...
🔴 2024-11-13 13:22:25 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:46:35 UTC Pre-commit check linux-x86_64-release-asan for b57d626 has started.
⚪ 2024-11-13 13:47:13 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:50:41 UTC ya make is running...
🟡 2024-11-13 14:54:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9088 9003 0 32 9 44

🟢 2024-11-13 14:56:00 UTC Build successful.
🟢 2024-11-13 14:56:32 UTC ydbd size 5.7 GiB changed* by +59.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ee51155 merge: b57d626 diff diff %
ydbd size 6 171 497 008 Bytes 6 171 558 256 Bytes +59.8 KiB +0.001%
ydbd stripped size 1 538 180 752 Bytes 1 538 195 472 Bytes +14.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:47:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for b57d626 has started.
⚪ 2024-11-13 13:47:49 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:50:54 UTC ya make is running...
🟡 2024-11-13 14:49:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40427 34741 0 13 5558 115

⚪ 2024-11-13 14:54:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-13 15:06:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 11 0 1 1 110

⚪ 2024-11-13 15:06:31 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-13 15:18:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 2 0 0 0 109

🟢 2024-11-13 15:18:19 UTC Build successful.
🟢 2024-11-13 15:18:51 UTC ydbd size 2.8 GiB changed* by +33.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ee51155 merge: b57d626 diff diff %
ydbd size 3 049 731 352 Bytes 3 049 766 072 Bytes +33.9 KiB +0.001%
ydbd stripped size 482 438 240 Bytes 482 440 480 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 00bc3bd into ydb-platform:main Nov 13, 2024
10 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-RD-enable-LLVM-in-purecalc-filters branch November 13, 2024 16:12
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Nov 13, 2024
@GrigoriyPA
YQ RD enable LLVM in purecalc filters (ydb-platform#11442)
5fe3ee7
This was referenced Nov 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorooleg dorooleg dorooleg approved these changes

@uzhastik uzhastik Awaiting requested review from uzhastik

@kardymonds kardymonds Awaiting requested review from kardymonds

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GrigoriyPA @dorooleg @uzhastik @kardymonds