issue-506: improve tests, report critical event when request info doe… #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yegorskii
commented
Mar 4, 2024
•
yegorskii
commented
- Improve tests - remove timeout from call to DispatchEvents
- Report critical event when request info does not have cancel routine but CancelRequest is called
- Make E_REJECTED error messages the same when tablet restarts
…s not have cancel routine but CancelRequest is called, make error messages when tablet restarts the same
qkrorlqr
reviewed
Mar 5, 2024
qkrorlqr
reviewed
Mar 5, 2024
qkrorlqr
approved these changes
Mar 5, 2024
EvgeniyKozev
approved these changes
Mar 5, 2024
yegorskii
deleted the
users/yegorskii/impruve-tests-introduce-critical-event
branch
qkrorlqr
pushed a commit
that referenced
this pull request
Jul 14, 2024
#633) * issue-506: improve tests, report critical event when request info does not have cancel routine but CancelRequest is called, make error messages when tablet restarts the same * align with nbs * update * update
qkrorlqr
added a commit
that referenced
this pull request
Jul 14, 2024
…es in the same shard, CreateNode for hardlinks) and [almost-]proper multitablet transactions (CreateNode + CreateNode, CreateHandle + CreateNode, UnlinkNode + UnlinkNode, RenameNode + UnlinkNode), metrics aggregation, less TABLET_VERIFYs (#1598) * issue-506: improve tests, report critical event when request info doe… (#633) * issue-506: improve tests, report critical event when request info does not have cancel routine but CancelRequest is called, make error messages when tablet restarts the same * align with nbs * update * update * issue-1350: replacing TABLET_VERIFY with impossible events + errors in CreateNode and CreateHandle (#1558) * issue-1350: replacing TABLET_VERIFY with impossible events + errors in UnlinkNode and RenameNode (#1564) * issue-1350: renamenode should work for files in the same shard (#1579) * issue-1350: followers->leader metrics aggregation (#1574) * issue-1350: metrics aggregation ut * issue-1350: followers->leader metrics aggregation * issue-1350: deleted unneeded include * issue-1350: OpLog - UnlinkNode (#1586) * issue-1350: UnlinkNode test with error from follower * issue-1350: UnlinkNode in follower - retries, logging operations to OpLog table, TODO: retry operations from OpLog upon tablet startup * issue-1350: OpLog - fixed RenameNode tx cleanup * issue-1350: replaying OpLog upon tablet restart + ut * issue-1350: logging UnlinkNode requests which happen upon RenameNode to OpLog (to replay them upon tablet restart), added a ut for this, fixed HandleUpdateConfig as well - merging follower-related fields into the config received from SchemeShard (#1592) * issue-1350: logging CreateNode requests to OpLog + some preparation for replaying them upon tablet restart, implemented DupCache for CreateNode requests for external nodes, retrying errors in TCreateNodeInFollowerActor (#1594) * issue-1350: hard links should work for external nodes (#1595) * issue-1350: hard linksshould work for external nodes * issue-1350: replaying CreateNode requests from OpLog upon tablet restart, retrying CreateNode requests happening upon CreateHandle requests, ut (#1597) * issue-1350: replaying CreateNode requests from OpLog upon tablet restart + ut * issue-1350: retrying CreateNode requests in followers upon CreateHandle requests in leader, preparation for replaying those CreateNode requests upon tablet restart * issue-1350: replaying CreateNode requests originating from CreateHandle requests upon tablet restart + ut * issue-1350: deleted TODOs that were implemented * update CMakeLists --------- Co-authored-by: yegorskii <137099343+yegorskii@users.noreply.github.com> Co-authored-by: Maxim Deb Natkh <debnatkh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.