Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1350: replaying CreateNode requests from OpLog upon tablet restart, retrying CreateNode requests happening upon CreateHandle requests, ut #1597

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

qkrorlqr
Copy link
Collaborator

Followup for #1594

#1350

@qkrorlqr qkrorlqr added the filestore Add this label to run only cloud/filestore build and tests on PR label Jul 14, 2024
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 4f12123.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1657 1657 0 0 0 0

@qkrorlqr qkrorlqr changed the title issue-1350: replaying CreateNode requests from OpLog upon tablet restart + ut issue-1350: replaying CreateNode requests from OpLog upon tablet restart, retrying CreateNode requests happening upon CreateHandle requests, ut Jul 14, 2024
…le requests in leader, preparation for replaying those CreateNode requests upon tablet restart
@qkrorlqr qkrorlqr force-pushed the users/qkrorlqr/issue-1350-create-node-oplog-replay branch from f082795 to 22df2d0 Compare July 14, 2024 14:46
@qkrorlqr qkrorlqr added the large-tests Launch large tests for PR label Jul 14, 2024
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 81e3448.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1666 1666 0 0 0 0

@qkrorlqr qkrorlqr merged commit a33fbbf into main Jul 14, 2024
9 of 10 checks passed
@qkrorlqr qkrorlqr deleted the users/qkrorlqr/issue-1350-create-node-oplog-replay branch July 14, 2024 16:09
qkrorlqr added a commit that referenced this pull request Jul 14, 2024
…art, retrying CreateNode requests happening upon CreateHandle requests, ut (#1597)

* issue-1350: replaying CreateNode requests from OpLog upon tablet restart + ut

* issue-1350: retrying CreateNode requests in followers upon CreateHandle requests in leader, preparation for replaying those CreateNode requests upon tablet restart

* issue-1350: replaying CreateNode requests originating from CreateHandle requests upon tablet restart + ut

* issue-1350: deleted TODOs that were implemented
qkrorlqr added a commit that referenced this pull request Jul 14, 2024
…es in the same shard, CreateNode for hardlinks) and [almost-]proper multitablet transactions (CreateNode + CreateNode, CreateHandle + CreateNode, UnlinkNode + UnlinkNode, RenameNode + UnlinkNode), metrics aggregation, less TABLET_VERIFYs (#1598)

* issue-506: improve tests, report critical event when request info doe… (#633)

* issue-506: improve tests, report critical event when request info does not have cancel routine but CancelRequest is called, make error messages when tablet restarts the same

* align with nbs

* update

* update

* issue-1350: replacing TABLET_VERIFY with impossible events + errors in CreateNode and CreateHandle (#1558)

* issue-1350: replacing TABLET_VERIFY with impossible events + errors in UnlinkNode and RenameNode (#1564)

* issue-1350: renamenode should work for files in the same shard (#1579)

* issue-1350: followers->leader metrics aggregation (#1574)

* issue-1350: metrics aggregation ut

* issue-1350: followers->leader metrics aggregation

* issue-1350: deleted unneeded include

* issue-1350: OpLog - UnlinkNode (#1586)

* issue-1350: UnlinkNode test with error from follower

* issue-1350: UnlinkNode in follower - retries, logging operations to OpLog table, TODO: retry operations from OpLog upon tablet startup

* issue-1350: OpLog - fixed RenameNode tx cleanup

* issue-1350: replaying OpLog upon tablet restart + ut

* issue-1350: logging UnlinkNode requests which happen upon RenameNode to OpLog (to replay them upon tablet restart), added a ut for this, fixed HandleUpdateConfig as well - merging follower-related fields into the config received from SchemeShard (#1592)

* issue-1350: logging CreateNode requests to OpLog + some preparation for replaying them upon tablet restart, implemented DupCache for CreateNode requests for external nodes, retrying errors in TCreateNodeInFollowerActor (#1594)

* issue-1350: hard links should work for external nodes (#1595)

* issue-1350: hard linksshould work for external nodes

* issue-1350: replaying CreateNode requests from OpLog upon tablet restart, retrying CreateNode requests happening upon CreateHandle requests, ut (#1597)

* issue-1350: replaying CreateNode requests from OpLog upon tablet restart + ut

* issue-1350: retrying CreateNode requests in followers upon CreateHandle requests in leader, preparation for replaying those CreateNode requests upon tablet restart

* issue-1350: replaying CreateNode requests originating from CreateHandle requests upon tablet restart + ut

* issue-1350: deleted TODOs that were implemented

* update CMakeLists

---------

Co-authored-by: yegorskii <137099343+yegorskii@users.noreply.github.com>
Co-authored-by: Maxim Deb Natkh <debnatkh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filestore Add this label to run only cloud/filestore build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants