issue-1350: 1. Cleanup is given priority over Compaction by default since it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage
qkrorlqr
added
large-tests
debnatkh
previously approved these changes
Jun 30, 2024
cloud/filestore/libs/storage/tablet/tablet_actor_compaction.cpp
Outdated
Show resolved
Hide resolved
debnatkh
approved these changes
Jun 30, 2024
yegorskii
approved these changes
Jun 30, 2024
qkrorlqr
added a commit
that referenced
this pull request
Jun 30, 2024
…ince it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage (#1522) * issue-1350: 1. Cleanup is given priority over Compaction by default since it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage * issue-1350: deleted unneeded include
qkrorlqr
added a commit
that referenced
this pull request
Jun 30, 2024
…or multitablet filesystems + some minor fixes/enhancements in filestore in general (#1523) * [Filestore] Add stat command to filestore client (#1453) Issue: #1474 * fixed filestore-client crash upon empty dir ls, added ls+rm+write test for filestore-client (#1505) * fixed filestore-client crash upon empty dir ls, added ls+rm+write test for filestore-client * fixed filestore-client crash upon empty dir ls, added ls+rm+write test for filestore-client - forgot client.py * issue-1350: simplified node creation in follower code, added a test for errors received from follower in this case, fixed DupCache entry commitment in CreateHandle, made TabletProxy immortal, deleted inactive pipe tracking and closure in TabletProxy, added some comments, fixed logging a bit (#1511) * issue-1350: simplified node creation in follower code, added a test for errors received from follower in this case, added some comments, fixed logging a bit * issue-1350: CreateHandle - if we need to create a node in one of the followers, we still need to commit DupCache entry; * issue-1350: TabletProxy should never die, TabletProxy should not track and close idle connections - 1. there is no need for that 2. it breaks leader<->follower session creation logic * filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation (#1520) * filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation * filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation - added missing include * filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation - added missing include * filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation - fixed build * issue-1350: implementing multitablet fs TODOs - DestroySession in followers, UnlinkNode (#1521) * issue-1350: destroying sessions in follower upon session destruction in leader * issue-1350: removing node refs in leader and unlinking nodes in followers upon UnlinkNode requests to leader * issue-1350: 1. Cleanup is given priority over Compaction by default since it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage (#1522) * issue-1350: 1. Cleanup is given priority over Compaction by default since it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage * issue-1350: deleted unneeded include * fixed CMakeLists.txt --------- Co-authored-by: Anton Myagkov <antomyagkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1350