Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filestore] Add stat command to filestore client #1453

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

antonmyagkov
Copy link
Collaborator

@antonmyagkov antonmyagkov commented Jun 19, 2024

Issue: #1474

@antonmyagkov antonmyagkov marked this pull request as ready for review June 19, 2024 17:14
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6dc27db.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5283 5280 0 0 1 2

@antonmyagkov antonmyagkov force-pushed the users/myagkov/filestore-client-stat-command branch from 6dc27db to 8b42b90 Compare June 19, 2024 18:05
Copy link
Collaborator

@qkrorlqr qkrorlqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще хотелось бы запилить какой-нибудь test suite для файлстора по типу cloud/blockstore/tests/client

@qkrorlqr qkrorlqr added the filestore Add this label to run only cloud/filestore build and tests on PR label Jun 19, 2024
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 8b42b90.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1563 1561 0 2 0 0

Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ce9c650.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1562 1562 0 0 0 0

Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit d373d41.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1563 1561 0 2 0 0

@antonmyagkov
Copy link
Collaborator Author

antonmyagkov commented Jun 20, 2024

Еще хотелось бы запилить какой-нибудь test suite для файлстора по типу cloud/blockstore/tests/client

Он уже есть. Добавил тест

@antonmyagkov antonmyagkov force-pushed the users/myagkov/filestore-client-stat-command branch from 0e28a7a to 5a815eb Compare June 20, 2024 12:33
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5a815eb.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1563 1563 0 0 0 0

@antonmyagkov antonmyagkov merged commit 44fc3ab into main Jun 21, 2024
10 of 12 checks passed
@antonmyagkov antonmyagkov deleted the users/myagkov/filestore-client-stat-command branch June 21, 2024 10:51
qkrorlqr pushed a commit that referenced this pull request Jun 30, 2024
qkrorlqr added a commit that referenced this pull request Jun 30, 2024
…or multitablet filesystems + some minor fixes/enhancements in filestore in general (#1523)

* [Filestore] Add stat command to filestore client (#1453)

Issue: #1474

* fixed filestore-client crash upon empty dir ls, added ls+rm+write test for filestore-client (#1505)

* fixed filestore-client crash upon empty dir ls, added ls+rm+write test for filestore-client

* fixed filestore-client crash upon empty dir ls, added ls+rm+write test for filestore-client
- forgot client.py

* issue-1350: simplified node creation in follower code, added a test for errors received from follower in this case, fixed DupCache entry commitment in CreateHandle, made TabletProxy immortal, deleted inactive pipe tracking and closure in TabletProxy, added some comments, fixed logging a bit (#1511)

* issue-1350: simplified node creation in follower code, added a test for errors received from follower in this case, added some comments, fixed logging a bit

* issue-1350: CreateHandle - if we need to create a node in one of the followers, we still need to commit DupCache entry;

* issue-1350: TabletProxy should never die, TabletProxy should not track and close idle connections - 1. there is no need for that 2. it breaks leader<->follower session creation logic

* filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation (#1520)

* filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation

* filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation - added missing include

* filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation - added missing include

* filestore loop shutdown: 1. E_CANCELLED code shouldn't be wrapped into MAKE_FILESTORE_ERROR 2. CompletionQueue should be notified about request cancellation - fixed build

* issue-1350: implementing multitablet fs TODOs - DestroySession in followers, UnlinkNode (#1521)

* issue-1350: destroying sessions in follower upon session destruction in leader

* issue-1350: removing node refs in leader and unlinking nodes in followers upon UnlinkNode requests to leader

* issue-1350: 1. Cleanup is given priority over Compaction by default since it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage (#1522)

* issue-1350: 1. Cleanup is given priority over Compaction by default since it's much faster and lighter but generally brings similar results (configurable via StorageServiceConfig) 2. Outputting follower info on monpage

* issue-1350: deleted unneeded include

* fixed CMakeLists.txt

---------

Co-authored-by: Anton Myagkov <antomyagkov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filestore Add this label to run only cloud/filestore build and tests on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants