Fix: respect patterns with "||" in the range during optimizeResolutions #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will increase the build size from 9.83 MB to 9.83 MB, an increase of 439 bytes (0%)
|
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…ns (yarnpkg#4562) **Summary** Fixes yarnpkg#4547 by testing each version against all ranges individually, rather than munging the patterns together to get a single range. **Test plan** Existing tests, plus a regression test to repro yarnpkg#4547: "manifest optimization respects versions with alternation"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4547 by testing each version against all ranges individually, rather than munging the patterns together to get a single range.
Test plan
Existing tests, plus a regression test to repro #4547: "manifest optimization respects versions with alternation"