Fix: Revert "Fix: unbound transitive dependency optimization" #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will decrease the build size from 9.83 MB to 9.82 MB, a decrease of 4.23 KB (0%)
|
mxmul
reviewed
Sep 27, 2017
| } | ||
|
|
||
| const availableVersions = this.getAllInfoForPatterns(collapsablePatterns).map(manifest => manifest.version); | ||
| const combinedRange = collapsablePatterns.map(pattern => normalizePattern(pattern).range).join(' '); |
There was a problem hiding this comment.
Could #4547 also be fixed by removing this semver range munging (patterns.join(' ')), and testing each version against every pattern in turn? This seems to be basically what semver.maxSatisfying is doing, but would do the correct thing with ranges containing "||".
There was a problem hiding this comment.
Not really. My initial approach was to do a proper intersection and I have the code locally. The problem is range can be exotic too like file:./a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4547, unfixes #3780 by reverting #4488 (commit 4020ccd).
Test plan
Existing unit tests.