feature: check --verify-tree for verifying node_modules structure #2419

bestander · 2017-01-10T02:04:16Z

Summary

Yarn needs an independend of resolving mechanism way of verifying node_modules correctness

Test plan

Manual test plan for React Native with these modifications:

removed node_modules/chalk (direct and hoisted dep)
removed node_modules/symbol-tree (dev dep)
modified version of node_modules/throat
modified version of node_modules/babel-core/node_modules/json5

$ ../yarn/bin/yarn check --verify-tree
yarn check v0.20.0-0
error "chalk" not installed
error "inquirer#chalk" not installed
error "throat" is wrong version: expected "^3.0.0", got "2.0.0"
error "eslint#chalk" not installed
error "jest-runtime#chalk" not installed
error "babel-core#babel-code-frame#chalk" not installed
error "babel-core#json5" is wrong version: expected "^0.5.0", got "0.1.0"
error "fbjs-scripts#gulp-util#chalk" not installed
error "request#har-validator#chalk" not installed
error "eslint#table#chalk" not installed
error "jest#jest-cli#chalk" not installed
error "jest-repl#jest-runtime#chalk" not installed
error "jest-repl#jest-util#chalk" not installed
error "jest-runtime#jest-config#chalk" not installed
error "fbjs-scripts#gulp-util#fancy-log#chalk" not installed
error "jest-runtime#jest-snapshot#jest-diff#chalk" not installed
error "jest-runtime#jest-snapshot#jest-matcher-utils#chalk" not installed
error "jest#jest-cli#jest-environment-jsdom#jsdom#symbol-tree" not installed
error "jest#jest-cli#node-notifier#cli-usage#marked-terminal#chalk" not installed
error Found 19 errors.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

$ ../yarn/bin/yarn check --integrity
yarn check v0.20.0-0
success Folder in sync.
✨  Done in 1.81s.

$ ../yarn/bin/yarn check
yarn check v0.20.0-0
error "babel-core#json5@^0.5.0" doesn't satisfy found match of "babel-core#json5@0.1.0"
error "chalk" not installed
error "throat" is wrong version: expected "3.0.0", got "2.0.0"
error "\u001b[2mjest#\u001b[22mjest-cli#throat@^3.0.0" doesn't satisfy found match of "throat@2.0.0"
error "babel-core#json5" is wrong version: expected "0.5.0", got "0.1.0"
error "\u001b[2mjsdom#\u001b[22msymbol-tree" not installed
error Found 6 errors.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

…ng in sync with common.js

bestander · 2017-01-10T02:04:31Z

Needs cleanup and tests

hpurmann · 2017-01-15T20:36:57Z

Thank you for building this!

bestander · 2017-01-15T23:30:25Z

Not sure what to do with optional deps because hoisting may cause some inconsistencies, I'll probably ignore them for this round.

bestander · 2017-01-16T15:18:02Z

Suggest a better name for the flag than commonjs

kentaromiura

looks pretty soundy to me, I'll rename the flag as proposed (or even a better solution), may be worthy pinging @kittens for better ideas.

kentaromiura · 2017-01-16T16:13:31Z

src/cli/commands/check.js

+        while (locations.length >= 0) {
+          let possiblePath;
+          if (locations.length > 0) {
+            possiblePath = path.join(registry.cwd, registry.folder,


nit

possiblePath = path.join( registry.cwd, registry.folder, locations.join(path.sep + registry.folder + path.sep) );

kentaromiura · 2017-01-16T16:19:55Z

src/cli/commands/check.js

@@ -15,6 +15,160 @@ export const noArguments = true;

 export function setFlags(commander: Object) {
  commander.option('--integrity');
+  commander.option('--commonjs');


As @davidaurelio suggested commonjs is probably not related to node js modules resolution, let's think of a better name:

--resolve-correctly

--verify-tree

--check-tree

other suggestion is to unify check and pass a level variable to it, so it will be something like --check lite --check deep --check full or --check 0...--check 2 or as an array (yargs supports this, not sure what commander does) --check 1 3

edmorley · 2017-03-10T20:40:45Z

Could you add some documentation for this on https://yarnpkg.com/lang/en/docs/cli/check/ ? :-)

bestander · 2017-03-10T20:43:09Z

Will do. I am reworking check functionality now, so I'll do it in one go in the next couple of weeks

…

On Fri, 10 Mar 2017 at 20:40, Ed Morley ***@***.***> wrote: Could you add some documentation for this on https://yarnpkg.com/lang/en/docs/cli/check/ ? :-) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2419 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWMSuC6NtDEIJBi39nEUu9kiXSunJks5rkbVVgaJpZM4Le81W> .

Simek · 2017-12-30T19:54:34Z

Documentation still lacks information about --verify-tree flag. Should I report this as an issue to yarn/website?

bestander · 2017-12-30T20:14:19Z

Yeah, or better send a PR :)

…

On Sat, Dec 30, 2017 at 11:54 AM Bartosz Kaszubowski < ***@***.***> wrote: Documentation still lacks information about --verify-tree flag. Should I report this as an issue to yarn/website? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2419 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWAIQpoxkx7ofSX_tqLe4zBYK_ReTks5tFpUEgaJpZM4Le81W> .

feature: check --commonjs for verifying of node_modules structure bei…

5b4ae1f

…ng in sync with common.js

bestander added 2 commits January 12, 2017 20:44

refactoring

8084c6f

refactored and localized

17f113f

bestander mentioned this pull request Jan 13, 2017

yarn install --production doesn't install correct dependencies #761

Closed

bestander and others added 5 commits January 13, 2017 12:57

lint fixes

93fb3ea

lint fixes

51028ed

minor fix

cb7a75d

added some tests

7ce6f35

added more tests

c2e7553

bestander changed the title ~~[WIP] feature: check --commonjs for verifying node_modules structure~~ feature: check --commonjs for verifying node_modules structure Jan 14, 2017

removed wrong comment

50cf3a4

kentaromiura reviewed Jan 16, 2017

View reviewed changes

bestander added 2 commits January 16, 2017 17:28

added deep check for tests

1823837

renamed to --verify-tree

d537625

bestander changed the title ~~feature: check --commonjs for verifying node_modules structure~~ feature: check --verify-tree for verifying node_modules structure Jan 16, 2017

bestander merged commit c98df16 into yarnpkg:master Jan 16, 2017

bestander mentioned this pull request Jan 16, 2017

yarn check "commonjs correctness" option #1934

Closed

edmorley mentioned this pull request Mar 10, 2017

Move docs out of the yarnpkg/website repository to this one #2891

Closed

jesstelford mentioned this pull request Apr 28, 2017

Swap prerequisite yarn check with frozen lockfile on install sindresorhus/np#149

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: check --verify-tree for verifying node_modules structure #2419

feature: check --verify-tree for verifying node_modules structure #2419

bestander commented Jan 10, 2017 •

edited

Loading

bestander commented Jan 10, 2017

hpurmann commented Jan 15, 2017

bestander commented Jan 15, 2017

bestander commented Jan 16, 2017

kentaromiura left a comment

kentaromiura Jan 16, 2017

kentaromiura Jan 16, 2017

edmorley commented Mar 10, 2017

bestander commented Mar 10, 2017 via email

Simek commented Dec 30, 2017

bestander commented Dec 30, 2017 via email

feature: check --verify-tree for verifying node_modules structure #2419

feature: check --verify-tree for verifying node_modules structure #2419

Conversation

bestander commented Jan 10, 2017 • edited Loading

bestander commented Jan 10, 2017

hpurmann commented Jan 15, 2017

bestander commented Jan 15, 2017

bestander commented Jan 16, 2017

kentaromiura left a comment

Choose a reason for hiding this comment

kentaromiura Jan 16, 2017

Choose a reason for hiding this comment

kentaromiura Jan 16, 2017

Choose a reason for hiding this comment

edmorley commented Mar 10, 2017

bestander commented Mar 10, 2017 via email

Simek commented Dec 30, 2017

bestander commented Dec 30, 2017 via email

bestander commented Jan 10, 2017 •

edited

Loading