Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn check "commonjs correctness" option #1934

Closed
bestander opened this issue Nov 18, 2016 · 1 comment
Closed

yarn check "commonjs correctness" option #1934

bestander opened this issue Nov 18, 2016 · 1 comment
Assignees

Comments

@bestander
Copy link
Member

bestander commented Nov 18, 2016

Do you want to request a feature or report a bug?
Feature

What is the current behavior?

check command uses internal resolution mechanism to verify node_modules correctness.
If there is a bug in resolver then install will install node_modules incorrectly and check will fail to identify it.

New behavior

yarn check --commonjs

We need an option for "correctness" check that makes sure that node_modules is consistent with Node.js requirements independent from Yarn's resolver.

For example (#1933), React Native node_modules installed by Yarn 0.16.1 is considered incorrect by check from Yarn 0.17.4.
However node_modules is correct from Node.js resolution point of view (is it? the tests did not catch it).
This will be a good feature for e2e "correctness" checks of Yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant