fix(pnpify): include wrapper for tsserverlibrary.js and return the entire tsserver
#2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it be enough? The TS server has quite a bit of extra boilerplate compared to the other wrappers 🤔 |
|
It's enough for it to work without go to definition, I made it a draft while I look into that |
merceyz
force-pushed
the
merceyz/fix/sdk-tsserverlibrary
branch
from
09a3e4b
to
1931c53
Compare
merceyz
changed the title
tsserverlibrary.jstsserverlibrary.js and return the entire tsserver
This was referenced Jun 19, 2021
arcanis
approved these changes
Jun 30, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The TypeScript SDK doesn't include a wrapper around the
tsserverlibrary.jsfile and only returns the Session instead of the entire lib intsserverFixes #2986
How did you fix it?
Generate a wrapper for it and return the entire tsserver
Checklist