Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard example - use Ember best practice form instead of .on() #208

Merged
merged 1 commit into from
Sep 16, 2017
Merged

keyboard example - use Ember best practice form instead of .on() #208

merged 1 commit into from
Sep 16, 2017

Commits on Jul 17, 2017

  1. do not use Ember's function prototype extensions in keyboard example 

    let's prefer prefer `didInsertElement()` and `willDestroyElement()` over the .on() syntax
see: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-function-prototype-extensions.md
    @caseywatts
    caseywatts committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    74c84d4 View commit details
    Browse the repository at this point in the history