keyboard example - use Ember best practice form instead of .on() #208

caseywatts · 2017-07-17T21:30:43Z

let's prefer prefer didInsertElement() and willDestroyElement() over the .on() syntax
see: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-function-prototype-extensions.md

let's prefer prefer `didInsertElement()` and `willDestroyElement()` over the .on() syntax see: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-function-prototype-extensions.md

lukemelia · 2017-09-16T21:52:51Z

Good call, @caseywatts!

do not use Ember's function prototype extensions in keyboard example

74c84d4

let's prefer prefer `didInsertElement()` and `willDestroyElement()` over the .on() syntax see: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-function-prototype-extensions.md

caseywatts changed the title ~~do not use Ember's function prototype extensions in keyboard example~~ keyboard example - use Ember best practice form instead of .on() Jul 18, 2017

lukemelia merged commit 2e88ad1 into yapplabs:master Sep 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keyboard example - use Ember best practice form instead of .on() #208

keyboard example - use Ember best practice form instead of .on() #208

caseywatts commented Jul 17, 2017

lukemelia commented Sep 16, 2017

keyboard example - use Ember best practice form instead of .on() #208

keyboard example - use Ember best practice form instead of .on() #208

Conversation

caseywatts commented Jul 17, 2017

lukemelia commented Sep 16, 2017