Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test cases #46

Merged
merged 10 commits into from
Jan 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ cache:
- node_modules
script:
- npm run lint
- npm run test:cov
after_script: "npm install coveralls && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage"
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ github 机器人:在服务端上启动一个基于 [koajs](http://koajs.com/)

[![Build Status](https://travis-ci.org/xuexb/github-bot.svg?branch=master)](https://travis-ci.org/xuexb/github-bot)
[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg)](http://standardjs.com)
[![Test Coverage](https://img.shields.io/coveralls/xuexb/github-bot/master.svg)](https://coveralls.io/r/xuexb/github-bot?branch=master)

## 声明

Expand Down
14 changes: 12 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@
"main": "src/app.js",
"scripts": {
"start": "NODE_ENV=development node src/app",
"lint": "eslint src/**/*.js --quiet",
"lint": "eslint src/**/*.js test/**/*.js --quiet",
"deploy": "pm2 start src/app.js --name=github-bot",
"precommit": "npm run lint",
"commitmsg": "validate-commit-msg"
"commitmsg": "validate-commit-msg",
"test:watch": "npm run test -- --watch",
"test:cov": "istanbul cover node_modules/mocha/bin/_mocha -- -t 5000 --recursive -R spec test/",
"test": "mocha --reporter spec --timeout 5000 --recursive test/"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -58,6 +61,8 @@
}
},
"devDependencies": {
"chai": "^4.1.2",
"chai-as-promised": "^7.1.1",
"eslint": "^4.9.0",
"eslint-config-standard": "^10.2.1",
"eslint-friendly-formatter": "^3.0.0",
Expand All @@ -66,6 +71,11 @@
"eslint-plugin-promise": "^3.6.0",
"eslint-plugin-standard": "^3.0.1",
"husky": "^0.14.3",
"istanbul": ">=1.0.0-alpha.2",
"mocha": "^4.0.1",
"mock-require": "^2.0.2",
"sinon": "^4.0.2",
"sinon-chai": "^2.14.0",
"validate-commit-msg": "^2.14.0"
}
}
11 changes: 6 additions & 5 deletions src/github.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* @author xuexb <fe.xiaowu@gmail.com>
*/

/* eslint-disable camelcase */
const GitHub = require('github')
const { toArray } = require('./utils')
const { appLog } = require('./logger')
Expand Down Expand Up @@ -258,7 +259,7 @@ module.exports = {
async removeLabelsToIssue (payload, name) {
const owner = payload.repository.owner.login
const repo = payload.repository.name
const number = payload.issues.number
const number = payload.issue.number
try {
await github.issues.removeLabel({
owner,
Expand All @@ -285,7 +286,7 @@ module.exports = {
* @param {boolean} options.prerelease 是否预发布
* @return {boolean} 是否成功
*/
async createRelease (payload, { tag_name, target_commitish, name, body, draft, prerelease }) {
async createRelease (payload, { tag_name, target_commitish, name, body, draft, prerelease } = {}) {
const owner = payload.repository.owner.login
const repo = payload.repository.name
try {
Expand Down Expand Up @@ -314,7 +315,7 @@ module.exports = {
*
* @return {Object | null}
*/
async getReleaseByTag (payload, { tag_name }) {
async getReleaseByTag (payload, { tag_name } = {}) {
const owner = payload.repository.owner.login
const repo = payload.repository.name
try {
Expand All @@ -339,7 +340,7 @@ module.exports = {
*
* @return {boolean} 是否成功
*/
async createReviewRequest (payload, { reviewers, team_reviewers }) {
async createReviewRequest (payload, { reviewers, team_reviewers } = {}) {
const owner = payload.repository.owner.login
const repo = payload.repository.name
const number = payload.pull_request.number
Expand Down Expand Up @@ -387,7 +388,7 @@ module.exports = {
* @param {string} options.head diff
* @return {Array | null}
*/
async compareCommits (payload, { base, head }) {
async compareCommits (payload, { base, head } = {}) {
const owner = payload.repository.owner.login
const repo = payload.repository.name
try {
Expand Down
Loading