Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test cases #46

Merged
merged 10 commits into from
Jan 15, 2018
Merged

feat: add test cases #46

merged 10 commits into from
Jan 15, 2018

Conversation

xuexb
Copy link
Owner

@xuexb xuexb commented Jan 14, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 42f2234 on feat/test into ** on master**.

@xuexb
Copy link
Owner Author

xuexb commented Jan 15, 2018

@yugasun 老铁有个 eslint 报错:

/home/travis/build/xuexb/github-bot/src/github.js
  288:35  error  Identifier 'tag_name' is not in camel case          camelcase
  288:45  error  Identifier 'target_commitish' is not in camel case  camelcase
  317:37  error  Identifier 'tag_name' is not in camel case          camelcase
  342:52  error  Identifier 'team_reviewers' is not in camel case    camelcase

@yugasun
Copy link
Collaborator

yugasun commented Jan 15, 2018

@xuexb 看到了,我把你修复吧。

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 06bfb13 on feat/test into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 551a327 on feat/test into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 40d9547 on feat/test into ** on master**.

@yugasun
Copy link
Collaborator

yugasun commented Jan 15, 2018

@xuexb 你这个PR线上改的太难受了,o(╯□╰)o,等合入master后,我直接修改eslint规则,禁用 camelcase

@yugasun yugasun merged commit 9ff0a52 into master Jan 15, 2018
@xuexb xuexb deleted the feat/test branch January 15, 2018 03:23
xuexb added a commit that referenced this pull request Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants