Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing github actions by updating test262 #32

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

alexandrenicol
Copy link
Contributor

@alexandrenicol alexandrenicol commented Mar 27, 2024

What?

Fixes the test:test262 step of the Github Action flow.

Should fix: #27

How?

  • updating the test262 dependency
  • updating the files whitelist in run_test262.js

Why?

  • This was preventing the Github Actions to succeed
  • Therefore preventing Yarn to publish the new tag release
  • Therefore preventing Webpack to update to any version above 1.9.0 (webpack uses this repository, and we're using webpack in our organisation, and because we're stuck with 1.9.0, our systems are flagging some of the security issues that were present in 1.9.0).

Anything else?

outcome of running npm run test:test262

@alexandrenicol ➜ /workspaces/acorn-import-attributes (fix-test-262) $ npm run test:test262

> acorn-import-attributes@1.9.3 test:test262
> node run_test262.js

Testing complete.
Summary:
 ✔ 71 valid programs parsed without error
 ✔ 5 invalid programs produced a parsing error
 ✔ 10 invalid programs did not produce a parsing error (and allowed by the whitelist file)
 ✔ 111 valid programs produced a parsing error (and allowed by the whitelist file)
 ✔ 97695 programs were skipped

Which is similar to what it was when first introduced in #13 (comment)

Fixes the `test:test262` step of the Github Action flow.

Should fix: xtuc#27

- updating the `test262` dependency
- updating the files whitelist in `run_test262.js`

- This was preventing the Github Actions to succeed
- Therefore preventing Yarn to public the new tag release
- Therefore preventing Webpack to update to any version above 1.9.0

```
@alexandrenicol ➜ /workspaces/acorn-import-attributes (fix-test-262) $ npm run test:test262

> acorn-import-attributes@1.9.3 test:test262
> node run_test262.js

Testing complete.
Summary:
 ✔ 71 valid programs parsed without error
 ✔ 5 invalid programs produced a parsing error
 ✔ 10 invalid programs did not produce a parsing error (and allowed by the whitelist file)
 ✔ 111 valid programs produced a parsing error (and allowed by the whitelist file)
 ✔ 97695 programs were skipped
```

Which is similar to what it was when first introduced in xtuc#13 (comment)
Copy link
Owner

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@xtuc xtuc merged commit 746778d into xtuc:main Mar 29, 2024
3 checks passed
@alexandrenicol alexandrenicol deleted the fix-test-262 branch April 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed for V1.9.2
2 participants