-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test-262 script #13
Conversation
Not related to your change but GitHub actions complains with:
|
CI fails with:
do you have any idea where that's coming from? |
I forgot to add a reference to the test262 repository: https://github.com/acornjs/acorn-class-fields/blob/89a1c7a6795e0fdac3e8fc8587ee6e1b9ea67dd0/package.json#L30 . I pinned it to the current latest commit.
|
it failed with now
I can help debug later today. |
I'm guessing the |
yap, that was the issue. 🙌 |
the current
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes the `test:test262` step of the Github Action flow. Should fix: xtuc#27 - updating the `test262` dependency - updating the files whitelist in `run_test262.js` - This was preventing the Github Actions to succeed - Therefore preventing Yarn to public the new tag release - Therefore preventing Webpack to update to any version above 1.9.0 ``` @alexandrenicol ➜ /workspaces/acorn-import-attributes (fix-test-262) $ npm run test:test262 > acorn-import-attributes@1.9.3 test:test262 > node run_test262.js Testing complete. Summary: ✔ 71 valid programs parsed without error ✔ 5 invalid programs produced a parsing error ✔ 10 invalid programs did not produce a parsing error (and allowed by the whitelist file) ✔ 111 valid programs produced a parsing error (and allowed by the whitelist file) ✔ 97695 programs were skipped ``` Which is similar to what it was when first introduced in xtuc#13 (comment)
adds test-262 runner. based on: https://github.com/acornjs/acorn-class-fields/blob/89a1c7a6795e0fdac3e8fc8587ee6e1b9ea67dd0/run_test262.js also bumped deps and added LTS versions to ci.
test-262 import assertions:
tc39/test262#2980
test-262 json modules:
tc39/test262#2999
added the failing tests to the whitelist: 3ead374#diff-0760fe08ac8e4dce6d416f554fcb99850cb731a9df9d37cd3743b9bf7bf80a52R14
not sure if all test-262 issues can be fixed and subsequently removed from the whitelist?