Passing cols or rows into ctor as undefined will break terminal #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
reviewed
Sep 2, 2021
| @@ -10,13 +10,23 @@ describe('OptionsService', () => { | |||
| describe('constructor', () => { | |||
| const originalError = console.error; | |||
| beforeEach(() => { | |||
| console.error = () => {}; | |||
| console.error = () => { }; | |||
There was a problem hiding this comment.
should revert this formatting change
meganrogge
reviewed
Sep 2, 2021
| it('uses default value if invalid constructor option value passed', () => { | ||
| assert.equal(new OptionsService({tabStopWidth: 0}).getOption('tabStopWidth'), DEFAULT_OPTIONS.tabStopWidth); | ||
| assert.equal(new OptionsService({ tabStopWidth: 0 }).getOption('tabStopWidth'), DEFAULT_OPTIONS.tabStopWidth); |
There was a problem hiding this comment.
Suggested change
| assert.equal(new OptionsService({ tabStopWidth: 0 }).getOption('tabStopWidth'), DEFAULT_OPTIONS.tabStopWidth); | |
| assert.equal(new OptionsService({tabStopWidth: 0}).getOption('tabStopWidth'), DEFAULT_OPTIONS.tabStopWidth); |
meganrogge
reviewed
Sep 2, 2021
| @@ -22,7 +22,7 @@ export const DEFAULT_OPTIONS: ITerminalOptions = Object.freeze({ | |||
| cursorStyle: 'block', | |||
| cursorWidth: 1, | |||
| customGlyphs: true, | |||
| bellSound: DEFAULT_BELL_SOUND, | |||
meganrogge
reviewed
Sep 2, 2021
| @@ -128,7 +128,7 @@ export class OptionsService implements IOptionsService { | |||
| break; | |||
| case 'cursorWidth': | |||
| value = Math.floor(value); | |||
| // Fall through for bounds check | |||
meganrogge
requested changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xterm.js/src/common/services/BufferService.ts
Lines 39 to 40 in 554f7da
Passing
undefinedto cols or rows would result in NaN. Passingnullworks as expected.Fixes #3329