Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing cols or rows into ctor as undefined will break terminal #3329

Closed
Tyriar opened this issue May 10, 2021 · 0 comments · Fixed by #3453
Closed

Passing cols or rows into ctor as undefined will break terminal #3329

Tyriar opened this issue May 10, 2021 · 0 comments · Fixed by #3453
Labels
type/bug Something is misbehaving
Milestone
4.14.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 10, 2021

This was causing microsoft/vscode#123502 to fail CI and the reason ended up being that cols/rows set to undefined breaks. null works fine, as does not setting any cols/rows property.
@Tyriar Tyriar added the type/bug Something is misbehaving label May 10, 2021
@Tyriar Tyriar added this to the 4.13.0 milestone May 10, 2021
@Tyriar Tyriar modified the milestones: 4.13.0, 4.14.0 Jun 24, 2021
@silamon silamon mentioned this issue Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
4.14.0
Development

Successfully merging a pull request may close this issue.

Passing cols or rows into ctor as undefined will break terminal silamon/xterm.js
1 participant
@Tyriar