Allow right-click paste (again) #293
Conversation
| @@ -1691,15 +1650,15 @@ Terminal.prototype.write = function(data) { | |||
| case '=': | |||
| this.log('Serial port requested application keypad.'); | |||
| this.applicationKeypad = true; | |||
| this.viewport.syncScrollArea(); | |||
| this.viewport.setApplicationMode(true); | |||
There was a problem hiding this comment.
Wow. I have no idea how this appeared here.
There was a problem hiding this comment.
Rewrote history, so this is gone now. Thanks for pointing out!
| on(this.textarea, 'paste', function (ev) { | ||
| pasteHandler.call(this, ev, term); | ||
| }); | ||
| on(this.element, 'contextmenu', function (ev) { |
There was a problem hiding this comment.
I think this might conflict with vscode which overrides the context menu to show options to create new terminal, paste and copy.
There was a problem hiding this comment.
Are you sure? I am not cancelling the event.
There was a problem hiding this comment.
@parisk wouldn't it cause 2 context menus to appear or something?
There was a problem hiding this comment.
No. All I am doing here is move the textarea when the context menu appears. Is there any easy way to try this out?
| return term.cancel(ev); | ||
| } | ||
| // Bind clipboard functionality | ||
| on(this.element, 'copy', copyHandler); |
There was a problem hiding this comment.
Should copy be exposed via the API so it can be done programmatically?
There was a problem hiding this comment.
All methods are already exposed in Clipboard.js. This also would not work in browsers, so I am skeptical about exposing such a public API.
parisk
force-pushed
the
issue-#202-fix-paste
branch
from
87c1b0f to
a224acb
Compare
|
Let me know when this is good to go and I'll do a quick test with vscode, I suspect there might be some breakages for Electron apps with custom right click menus. |
|
@Tyriar feel free to test |
Allow right-click paste in the terminal, with the hidden textarea.
For the purposes of this PR, I branched out all clipboard logic into a new module and documented everything with JSDoc.
This PR closes #202 and renders #232 useless for the moment.