Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement virtual selection #232

Closed
wants to merge 1 commit into from
Closed

Conversation

parisk
Copy link
Contributor

@parisk parisk commented Aug 17, 2016

This is still in very early PoC state and it is barely usable. I am opening this mainly for feedback on the implementation.

Still lots to be done here.

This is very slow. Really.
}

.xterm-selection{
background-color: yellow;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here just to make sure that the virtual selection stands out.

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2016

I was thinking to bind mouseup/mousedown, tracking the start and end position. Then draw 1-3+ rectangles divs under the text but over the background, depending on which text was selected. This would enable things like selecting more text than is in the viewport and scrolling the terminal when the mouse is down and the cursor approaches the top/bottom boundaries.

Some things to consider:

  • In a browser, copying will probably require copying the text to a temporary textarea
  • Middle click to paste may be messed up?
  • I would like to keep the inverted selection color on vscode so maybe more than 3 rectangles would be required, what about adding .selected to span elements when the entire span is selected

@parisk parisk added work-in-progress Do not merge and removed work-in-progress Do not merge labels Aug 24, 2016
@parisk
Copy link
Contributor Author

parisk commented Sep 28, 2016

Closing because of #293.

@parisk parisk closed this Sep 28, 2016
@parisk parisk deleted the virtual-selection branch October 31, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants