Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cont_t for Core 2.4.2 and higher #1195

Merged
merged 3 commits into from
Sep 16, 2018
Merged

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Sep 12, 2018

88e2ecc#diff-bd6de869be74ac5eaf90f23e4b75b857 added extern g_cont:

extern "C" {
#include <cont.h>
extern cont_t g_cont;
}

but it is no longer defined in 'master' of esp8266/Arduino, now it is cont_t* g_pcont:
esp8266/Arduino@5d5ea92#diff-3fa12668b289ccb95b7ab334833a4ba8L35

This PR:

  • added define check for core version when using g_cont/g_pcont
  • updated travis envs to use newest platform, so this is tested

@mcspr
Copy link
Collaborator Author

mcspr commented Sep 13, 2018

rebased.
platform = espressif8266@>=1.8.0 was not working as expected. newer platform must be installed manually.

@mcspr
Copy link
Collaborator Author

mcspr commented Sep 13, 2018

esp8266/Arduino issue about this esp8266/Arduino#5118
if pr linked to it comes with 2.5.0 - ifdef here will be g_cont 2.3.0, 2.4.0, 2.4.1, g_pcont 2.4.2 and built-in ESP class method for latter

@xoseperez xoseperez merged commit e7845ac into xoseperez:dev Sep 16, 2018
@Misiu
Copy link

Misiu commented Sep 17, 2018

@mcspr what about ESP.getFreeContStack() mentioned here.
PR containing this function is already merged.

@mcspr
Copy link
Collaborator Author

mcspr commented Sep 17, 2018

@Misiu yep, you are right. Right when I wrote my comment, pr was merged and I missed notification.
I'll open another one with new method

@Misiu
Copy link

Misiu commented Sep 18, 2018

@mcspr that was fast 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants