implement EspClass::getFreeContStack method #5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
reviewed
Sep 13, 2018
cores/esp8266/Esp.cpp
Outdated
| @@ -177,6 +178,12 @@ uint16_t EspClass::getMaxFreeBlockSize(void) | |||
| return umm_max_block_size(); | |||
| } | |||
|
|
|||
| uint32_t EspClass::getFreeContStack() | |||
| { | |||
| extern cont_t* g_pcont; | |||
There was a problem hiding this comment.
This declaration is already done in cont.h
As a general question, why don't we write these trivial functions directly inside the class ?
This would have the effect of reducing the final image size if they are not used.
There was a problem hiding this comment.
Since -ffunction-sections is used, all unused functions should be stripped anyway, right?
There was a problem hiding this comment.
Damn right !
I was totally unaware of that and I thought that was the LTO feature that we don't have.
So I uselessly separated some code from Esp.cpp namely Esp-frag.cpp and Esp-version.cpp.
Thanks for opening my eyes, I will seek details on the differences between these two gcc/ld features.
d-a-v
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5118