buttonBarView

[codwam]

BaseButtonBarPagerTabStripViewController.swift:
buttonBarView in code crash

[gonghao]

It's very useful! Hope to merge into master! 👍

[santiagofm]

We totally missed the error with the weak reference, good catch !
But i'd rather we have the same thing that was done in ButtonBarPagerTabStripViewController so if you can change it i'll merge it.
Also, please remove the changes to the IndicatorInfo that seem to be related to some custom implementation of a badge and don't forget to squash everything into one commit.

Cheers

[gonghao]

@santiagofm Maybe we should make a discussion about IndicatorInfo in #378

[codwam]

@santiagofm
1.
The weak properties you can modify, it's easy.
2.
The IndicatorInfo extension some properties is needed.
Firstly: The Youtube example is simple, and my cell has more than three labels !!!
Seondly: extenstion IndicatorInfo then use runtime to extension is no effect, case it's struct !!!

[santiagofm]

@gonghao Sure

@codwam Yes, i understand. Still, i think it would be better to have this PR fix the weak buttonBarView issue so we merge it immediately and discuss what to do with IndicatorInfo in #378.

[codwam]

I'm not familiar with Pull Request，what should I do？

[santiagofm]

@codwam I think squashing those 4 commits into just one and then amending it to remove the IndicatorInfo stuff you should be good to go

[codwam]

Sorry, I don't know how to revert.