Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userInfo or other property to IndicatorInfo to support more situations #378

Open
gonghao opened this issue May 18, 2017 · 1 comment

Comments

@gonghao
Copy link

gonghao commented May 18, 2017

Recently I need to add badge support for Tab, but I found the IndicatorInfo do not support property other than title, image and highlightedImage. It isn't flexible enough to customize the Tab, although I write the TabCell to do so, I have to use the image property to do some hack.

Maybe we should add the extension ability for IndicatorInfo to have a more flexible use.

If it was OK, I very appreciate making a pull request about this.

Thank you.

@gonghao gonghao mentioned this issue May 18, 2017
@santiagofm
Copy link
Contributor

santiagofm commented May 18, 2017

Hey @gonghao, we agree with you and had some discussion based on #368 (comment) about what to do- making IndicatorInfo a protocol for example- but it may require some heavy restructuring and decided to add the task to our backlog and work on it after we reduce the issue count.
That said, feel free to open a PR with whatever you have in mind.

Cheers

santiagofm pushed a commit that referenced this issue May 22, 2017
santiagofm pushed a commit that referenced this issue Nov 16, 2017
bonokite pushed a commit to bonokite/XLPagerTabStrip that referenced this issue Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants