-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#390 & #393 - Added garbarge providers, implemented cleaning providers functionality #391
Conversation
clarification to prevent questions as in xirixiz#389
Requested in xirixiz#393 implementation of cleanprofs function. Created format_postal_code function to prevent code duplicate and improve maintainablity
… existing garbage collectors
Added cleanprofs as the first cleaning provider
added PMD+Rest
change to lower
added "bulkyrestwaste": "pmd-restafval"
Perfect! Thanks for you contribution. I didn't get any notification about the outstanding issues, but I`ll merge it and draft a new release tomorrow. |
Drafted a pre-release. If it's working fine, I can release it. https://github.com/xirixiz/homeassistant-afvalwijzer/releases/tag/2025.02.01 |
Zojuist heb ik de code meteen getest, maar er zitten toch wel wat foutjes in. Ik had de code nog niet goed bekeken, maar zie ook nog wel wat puntjes die niet nodig waren. Ik zal een branch aanmaken op basis van de merged code (nu in main). Dan zal ik het fixen en een MR aanmaken en jou taggen, dan zie je wat ik bedoel. Maar hoe dan ook altijd super wanneer iemand de moeite neemt om een bijdrage te leveren. We doen dit uiteindelijk allemaal gratis voor de community. |
Created and implemented the Irado garbage collector as requested in #390
Created and implemented the container cleaning provider functionality and added cleanprofs as the first cleaning collector