Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#390 & #393 - Added garbarge providers, implemented cleaning providers functionality #391

Merged
merged 11 commits into from
Feb 28, 2025

Conversation

PatrickSt1991
Copy link
Contributor

@PatrickSt1991 PatrickSt1991 commented Feb 8, 2025

Created and implemented the Irado garbage collector as requested in #390

Created and implemented the container cleaning provider functionality and added cleanprofs as the first cleaning collector

clarification to prevent questions as in xirixiz#389
Requested in xirixiz#393 implementation of cleanprofs function.

Created format_postal_code function to prevent code duplicate and improve maintainablity
@PatrickSt1991 PatrickSt1991 changed the title #390 - Add Irado as garbarge provider (next pickups) #390 & #393 - Added Irado and Cleanprofs as garbarge providers Feb 19, 2025
@PatrickSt1991 PatrickSt1991 changed the title #390 & #393 - Added Irado and Cleanprofs as garbarge providers #390 & #393 - Added garbarge providers, implemented cleaning providers functionality Feb 23, 2025
change to lower
added "bulkyrestwaste": "pmd-restafval"
@xirixiz
Copy link
Owner

xirixiz commented Feb 28, 2025

Perfect! Thanks for you contribution. I didn't get any notification about the outstanding issues, but I`ll merge it and draft a new release tomorrow.

@xirixiz xirixiz merged commit c23526b into xirixiz:main Feb 28, 2025
0 of 2 checks passed
@xirixiz
Copy link
Owner

xirixiz commented Feb 28, 2025

Drafted a pre-release. If it's working fine, I can release it.

https://github.com/xirixiz/homeassistant-afvalwijzer/releases/tag/2025.02.01

@xirixiz
Copy link
Owner

xirixiz commented Feb 28, 2025

Zojuist heb ik de code meteen getest, maar er zitten toch wel wat foutjes in. Ik had de code nog niet goed bekeken, maar zie ook nog wel wat puntjes die niet nodig waren. Ik zal een branch aanmaken op basis van de merged code (nu in main). Dan zal ik het fixen en een MR aanmaken en jou taggen, dan zie je wat ik bedoel. Maar hoe dan ook altijd super wanneer iemand de moeite neemt om een bijdrage te leveren. We doen dit uiteindelijk allemaal gratis voor de community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants