-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cleanprofs data to Afvalwijzer #393
Comments
Extra contextI have added the Cleanprofs integration to the MMM-Afvalwijzer module. The data from Cleanprofs can be retrieved through a simple API call. No API key is needed whatsoever. After calling the API, the Cleanprofs data is appended to the afvalwijzer data. Just with a visual of a waterdrop. This is how it looks on the Magic Mirror: API Example
Example input:
|
@Dennis-Rosenbaum @HenkdeVlaam hebben jullie een postcode met huisnummer combinatie die ik kan gebruiken? dan kan ik de api results even bekijken en misschien verwerken |
|
Requested in xirixiz#393 implementation of cleanprofs function. Created format_postal_code function to prevent code duplicate and improve maintainablity
@HenkdeVlaam tnx! you're request is implemented in this PR #391 After it's merged it will become available |
Thanks! |
No idea.. that's up to the repo owner and that's not me. Just to clarify, I've added cleanprofs as a new garbage collection, that's what you wanted right? It will show up in the list and when chosen it will show the next pickup dates. Or do you want it to append to a existing one, like MMM-Afvalwijzer module does? Cause if it's the latter, I need to change it and test it with the company that's collecting your waste.. If so, can you provide me with the company that's collecting your waste? |
Hello Patrick,Thanks for your reply.Ideally the cleaner info should be “integrated” in the main Afvalwijzer add-on.Users initially have to select the city where they live and where the postal code they gave as input during the initial configuration is situated . In this process they should also set if they have a prescription to a local container cleaner (here two are active)I live in Almere and our waste collector is XimmioIf the above as preferred integration is too complex then implementing the cleaning providers as an other garbage collector could be an alternative as long as the software allows that two “garbage collectors” are active in parrallel and their agendas are synchronised Best regardsHenkOp 19 feb 2025 om 15:27 heeft Patrick ***@***.***> het volgende geschreven:
No idea.. that's up to the repo owner and that's not me.
Just to clarify, I've added cleanprofs as a new garbage collection, that's what you wanted right?
It will show up in the list and when chosen it will show the next pickup dates.
Or do you want it to append to a existing one, like MMM-Afvalwijzer module does?
Cause if it's the latter, I need to change it and test it with the company that's collecting your waste..
If so, can you provide me with the company that's collecting your waste?—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
PatrickSt1991 left a comment (xirixiz/homeassistant-afvalwijzer#393)
No idea.. that's up to the repo owner and that's not me.
Just to clarify, I've added cleanprofs as a new garbage collection, that's what you wanted right?
It will show up in the list and when chosen it will show the next pickup dates.
Or do you want it to append to a existing one, like MMM-Afvalwijzer module does?
Cause if it's the latter, I need to change it and test it with the company that's collecting your waste..
If so, can you provide me with the company that's collecting your waste?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Okay, no problem, I'll start working on it today to implement it as option a option |
Great!People can after some time kill their cleaning abbo or change to a new company, so this choice should also be possible to modify by the user “on the run”Op 19 feb 2025 om 15:48 heeft Patrick ***@***.***> het volgende geschreven:
Okay, no problem, I'll start working on it today to implement it as option a option—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
PatrickSt1991 left a comment (xirixiz/homeassistant-afvalwijzer#393)
Okay, no problem, I'll start working on it today to implement it as option a option
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@HenkdeVlaam Your request is now partially implemented in the pull request. I've removed it as a garbage collector because it isn't a collector—it's a cleaning company. Once the PR is merged, the plugin will contain a new option:
So, all in all, it's not exactly the same as what @Dennis-Rosenbaum created with two images side by side. Instead, it's a new sensor but still within the same afvalwijzer instance, so there's no need to run them in parallel. The only thing that isn't implemented yet is the option to reconfigure it on the fly. That would require a significant code change, so I might start working on it another day. I hope this is what you were looking for! And this is what I used for the image for the sensor, in configuration.yaml homeassistant:
customize_glob:
"sensor.afvalwijzer_cleaning*":
entity_picture: /local/afvalwijzer/cleaning.jpg |
Great!! And a surprisingly fast implementation it is One question. Regards, |
Unfortunately, yes. Since there's a change to That said, this PR still needs to be merged. However, if you don’t want to wait, you can use my fork: Afvalwijzer with cleaning company If you need any help setting up Afvalwijzer, just let me know. Do you have a lot of custom work done? If not, the benefit of running Verwijderen is that it will only delete the sensors but won’t affect any of your custom YAML files. Once you reinstall it, the sensors will return with the same names. |
Thanks! Maybe I will try to implement your fork. If I need some support will let you know. |
That doesn't sound like a hard thing to fix, probably just have to add it in The waste mapping happens there. So if your json return is |
De sensor is nu: sensor.afvalwijzer_bulkyrestwaste
Ik zou graag willen dat hij heet: sensor.afvalwijzer_pmd+rest
Kan dat?
Groeten,
Henk
Van: Patrick ***@***.***>
Datum: maandag, 24 februari 2025 om 14:24
Aan: xirixiz/homeassistant-afvalwijzer ***@***.***>
CC: HenkdeVlaam ***@***.***>, Mention ***@***.***>
Onderwerp: Re: [xirixiz/homeassistant-afvalwijzer] Add Cleanprofs data to Afvalwijzer (Issue #393)
That doesn't sound like a hard thing to fix, probably just have to add it in main_functions.py
The waste mapping happens there.
So if your json return is PMD+Rest then I'll just add "PMD+Rest":"pmd-restafval" and Bob's your uncle
—
Reply to this email directly, view it on GitHub<#393 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A36LUIKN4255Q2REM4P2ECD2RMMRZAVCNFSM6AAAAABXI4ROQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQYDSNZXGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[PatrickSt1991]PatrickSt1991 left a comment (xirixiz/homeassistant-afvalwijzer#393)<#393 (comment)>
That doesn't sound like a hard thing to fix, probably just have to add it in main_functions.py
The waste mapping happens there.
So if your json return is PMD+Rest then I'll just add "PMD+Rest":"pmd-restafval" and Bob's your uncle
—
Reply to this email directly, view it on GitHub<#393 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A36LUIKN4255Q2REM4P2ECD2RMMRZAVCNFSM6AAAAABXI4ROQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQYDSNZXGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Ik heb hem nu als dit toegevoegd: Zo blijft de sensor in lijn met de rest van de sensoren. Je sensor wordt dan; |
ThanksOp 24 feb 2025 om 20:25 heeft Patrick ***@***.***> het volgende geschreven:
Ik heb hem nu als dit toegevoegd:
"bulkyrestwaste": "pmd-restafval"
Zo blijft de sensor in lijn met de rest van de sensoren.
Je sensor wordt dan;
sensor.afvalwijzer pmd-restafval—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
PatrickSt1991 left a comment (xirixiz/homeassistant-afvalwijzer#393)
Ik heb hem nu als dit toegevoegd:
"bulkyrestwaste": "pmd-restafval"
Zo blijft de sensor in lijn met de rest van de sensoren.
Je sensor wordt dan;
sensor.afvalwijzer pmd-restafval
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…s functionality (#391) * Add Irado as garbarge provider (next pickups) * Update README.md clarification to prevent questions as in #389 * Updated Irado to pickups API for longer date range * Implementation of Cleanprofs Requested in #393 implementation of cleanprofs function. Created format_postal_code function to prevent code duplicate and improve maintainablity * empty commit to rebase * Removal of cleanprofs as a garbage collector, needs to be addition to existing garbage collectors * Implemented the cleaning provider functionality. Added cleanprofs as the first cleaning provider * Update main_functions.py added PMD+Rest * Update main_functions.py change to lower * Update main_functions.py added "bulkyrestwaste": "pmd-restafval"
Sorry for the late response folks, but many thanks for the great contribution! |
Thanks for your cooperation!Any tips how to implement the cleaning add-on without destroying the afvalwijzer implementation?RegardsHenkOp 28 feb 2025 om 20:34 heeft Bram van Dartel ***@***.***> het volgende geschreven:
Sorry for the late response folks, but many thanks for the great contribution!—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
xirixiz left a comment (xirixiz/homeassistant-afvalwijzer#393)
Sorry for the late response folks, but many thanks for the great contribution!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Feature request
Now that the Afvalwijzer runs on our Home Assistant instance we would like to have the information of the Cleanprofs added to the integration.
After some search on Github we found a Cleanprofs integration for the MMM (Magic Mirror Module) See: (https://github.com/gertperdZA/MMM-Afvalwijzer)
It would be nice if this function can be integrated in the Afvalwijzer for Home Assistant without the need for installing the MMM integration in Home Assistant in order to keep things less complex.
What version of the integration are you using?
Afvalwijzer 2025.01.01
Anything in the logs that might be useful for us?
Additional information
No response
The text was updated successfully, but these errors were encountered: