Fix up setup class #687
Fix up setup class #687
Conversation
Removes uninstall.php and registers an uninstall hook instead. Removes dependency on plugin methods.
|
Would be great to get this unit tested |
|
@willmot these unit tests don't work. trying something else |
Seems like its the preferred method
|
@owaincuvelier to do some QA to make sure activating, deactivating and uninstallation is working correctly. You can test the cron removal by using something like Cron Control |
|
Looks like it needs master merging, then should be good to go. |
Conflicts: backupwordpress.php classes/class-setup.php
|
@owaincuvelier did you get a chance to review? |
|
@pdewouters will do this in a few minutes! |
|
|
||
| // Remove the backups directory | ||
| require_once( dirname( __FILE__ ) . '/../hm-backup/hm-backup.php' ); |
There was a problem hiding this comment.
This no longer exists so caused fatal error
|
|
||
| // Remove the backups directory | ||
| require_once( dirname( __FILE__ ) . '/../hm-backup/hm-backup.php' ); | ||
| require_once( dirname( __FILE__ ) . '/class-hmbkp-path.php' ); |
There was a problem hiding this comment.
I think the path here should be '/classes/class-path.php'
|
All database entires were removed except the windows azure licence entry: All the cronjob are successfully removed on deactivation. Just need to update the paths for |
|
should also delete the backups directory |
So we're deleting peoples backups on deletion of the plugin? |
Yeah not sure we should be doing that actually |
|
Not an issue - we can add an opt-in setting "delete all data on uninstall" |
|
Going to merge this |
|
Sorry for the delay. This was good to merge. |
|
Changes Unknown when pulling acad348 on fixup-setup-class into * on master*. |
The code was not functional, this PR fixes that by also removing the need to require plugin files and use plugin methods to delete options.
I still needed to require a few files for
hmbkp_rmdirtree