IIS: No download links #671
Conversation
|
Reports of this are stacking up. I'll have a bash at a patch. |
|
as discussed, assigning to you @owaincuvelier and @willmot to help. Let me know if you manage to fix any of these IIS bugs so we can release a bugfix version with also #687 |
|
So this is fairly low-level but I've found that: get_path() is returning a path with back slashes, and it's being strpos'd agains't this path, which contains only forward slashes. So the check fails. Windows is able to handle both / and . Will post another update here as I have run mid-way through looking at the code. |
|
Cool, so probably |
|
That's what j was just looking into before I left — On Mon, Jan 26, 2015 at 6:06 PM, Tom Willmot notifications@github.com
|
|
Instead of running |
Conflicts: classes/class-path.php
|
@owaincuvelier can you test on IIS please? Thanks :) |
| $default = array(); | ||
| } | ||
|
|
||
| $upload_dir = wp_upload_dir(); | ||
|
|
||
| if ( false === $fallback = glob( $upload_dir['basedir'] . '/backupwordpress-*-backups', GLOB_ONLYDIR ) ) { | ||
| if ( false === $fallback = glob( $upload_dir['basedir'] . DIRECTORY_SEPARATOR . 'backupwordpress-*-backups', GLOB_ONLYDIR ) ) { |
There was a problem hiding this comment.
No need for DIRECTORY_SEPARATOR as Windows supports / fine.
|
As discussed, going to give this a little more thought |
|
This actually seems to have been fixed by #667 |
|
You're right, just installed BWP latest master on my Webmatrix install, and I can download backups |
IIS servers don't display download links.