Fix issue 5649: makedhcp misleading error message #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obihoernchen
requested changes
Sep 21, 2018
xCAT-server/lib/xcat/plugins/dhcp.pm
Outdated
| return; | ||
| } | ||
| } else { | ||
| my $tmp_server = inet_aton($node_server); | ||
| unless ($tmp_server) { | ||
| $callback->({ error => ["Unable to resolve the tftpserver for $node"], errorcode => [1] }); | ||
| $callback->({ error => ["Unable to determine the tftpserver for $node, please makesure \"xcatmaster\" is set correctly"], errorcode => [1] }); |
There was a problem hiding this comment.
I think resolve is the correct term here?
I think inet_aton($node_server); is trying to resolve it, isn't it?
There was a problem hiding this comment.
A suggestion to improve the message. In all three messages instead of "please make sure" use "verify".
|
hi, @Obihoernchen and @gurevichmark , modified. |
Obihoernchen
approved these changes
Sep 25, 2018
gurevichmark
approved these changes
Sep 25, 2018
|
I am OK to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to fix issue #5649
The modification include
Modify the warning message if failed to get/resolve
xcatmasterThe UT result