makedhcp misleading error message

[Obihoernchen]

If you do net set xcatmaster for your and the node is in a remote network which isn't directly attached to the xCAT server the following error is shown:

[root@xcat ~]# makedhcp <node>
Error: [xcat]: Unable to determine the tftpserver for <node>

This is misleading because tftpserver was set for all networks.
The real issue was the missing xcatmaster attribute.

The following code throws this error:
https://github.com/xcat2/xcat-core/blob/master/xCAT-server/lib/xcat/plugins/dhcp.pm#L530-L558

This code looks for xcatmaster, not tftpserver. Therefore, in my opinion the message should include xcatmaster instead of tftpserver.

[zet809]

hi, @Obihoernchen , thanks very much for point this out, the xcatmaster shall be the tftpserver of the compute node, but the message is really misleading.

[zet809]

I have modify the warning message as Unable to determine the tftpserver for <mynode>, please makesure "xcatmaster" is set correctly in PR #5651

[Obihoernchen]

cool thanks 👍

[Obihoernchen]

#5651 merged