rspconfig admin_password for OpenBMC #4371

xuweibj · 2017-11-24T08:26:41Z

rspconfig admin_password

# rspconfig mid05tor12cn02 admin_passwd=0penBmc,0penBmc1
mid05tor12cn02: BMC Setting Password...

run when xcatdebugmode=1

# rspconfig mid05tor12cn02 admin_passwd=0penBmc,0penBmc1
Fri Nov 24 03:07:07 2017 mid05tor12cn02: [openbmc_debug] curl -k -c cjar -H "Content-Type: application/json" -d '{ "data": ["root", "xxxxxx"] }' https://172.11.139.2/login
Fri Nov 24 03:07:07 2017 mid05tor12cn02: [openbmc_debug] login_response 200 OK
Fri Nov 24 03:07:07 2017 mid05tor12cn02: [openbmc_debug] curl -k -b cjar -X POST -H "Content-Type: application/json" -d '{"data":["0penBmc1"]}' https://172.11.139.2/xyz/openbmc_project/user/root/action/SetPassword
Fri Nov 24 03:07:07 2017 mid05tor12cn02: [openbmc_debug] rspconfig_set_response 200 OK
mid05tor12cn02: BMC Setting Password...

currentpasswd is wrong

# rspconfig mid05tor12cn02 admin_passwd=0penBmc1,0penBmc
mid05tor12cn02: Please input correct BMC password.

error

# rspconfig mid05tor12cn16 admin_passwd=0penBmc1,0penBmc,222
mid05tor12cn16: Error: Invalid parameter for option admin_passwd: 0penBmc1,0penBmc,222

When test, encountered that received "500 Internal Error" from OpenBMC. But run again success.

# curl -k -b cjar -X POST -H "Content-Type: application/json" -d '{ "data" : ["0penBmc"] }' https://172.11.139.2/xyz/openbmc_project/user/root/action/SetPassword
{
  "data": {
    "description": "Internal Server Error",
    "exception": "DBusException('The operation failed internally.',)",
    "traceback": [
      "Traceback (most recent call last):",
      "  File \"/usr/lib/python2.7/site-packages/bottle.py\", line 862, in _handle",
      "    return route.call(**args)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 913, in __call__",
      "    return self.callback(*a, **kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 970, in wrap",
      "    return callback(*a, **kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 1153, in __call__",
      "    return self.callback(*a, **kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 1127, in wrap",
      "    return self.to_jsonp(callback(*a, **kw))",
      "  File \"/usr/lib/python2.7/site-packages/bottle.py\", line 1734, in wrapper",
      "    rv = callback(*a, **ka)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 1092, in wrap",
      "    data = callback(*a, **kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 1021, in wrap",
      "    return callback(*a, **kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 1052, in wrap",
      "    return callback(*a, **kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 209, in __call__",
      "    return getattr(self, 'do_' + request.method.lower())(**kw)",
      "  File \"/usr/lib/python2.7/site-packages/obmc/wsgi/apps/rest_dbus.py\", line 349, in do_post",
      "    item(*request.parameter_list)",
      "  File \"/usr/lib/python2.7/site-packages/dbus/proxies.py\", line 145, in __call__",
      "    **keywords)",
      "  File \"/usr/lib/python2.7/site-packages/dbus/connection.py\", line 651, in call_blocking",
      "    message, timeout)",
      "DBusException: xyz.openbmc_project.Common.Error.InternalFailure: The operation failed internally."
    ]
  },
  "message": "500 Internal Server Error",
  "status": "error"
}

xcatbot · 2017-11-24T08:28:59Z

CI CHECK RESULT : > PR FORMAT CORRECT> BUILD SUCCESSFUL > INSTALL XCAT SUCCESSFUL> CODE SYNTAX CORRECT> FAST REGRESSION TEST Successful: Totalcase 215 Pass 215 failed 0

whowutwut · 2017-11-27T20:46:33Z

@xuweibj At what level of the FW code is this enabled?

Could we also add in UT cases for this, I have PR #4379 If @hu-weihua merges it, we can add in the basic UT cases that you printed above and build up the automation. If we do something to set/change this, we should set it back to what it was at the end of the testing... Or just not automate that.

whowutwut · 2017-11-27T20:47:30Z

xCAT-server/lib/xcat/plugins/openbmc.pm

@@ -310,6 +310,14 @@ my %status_info = (
    RSPCONFIG_GET_RESPONSE => {
        process        => \&rspconfig_response,
    },
+    RSPCONFIG_PASSWD_REQUEST => {


What do we use "PASSWD_REQUEST" as the name for this? The action is "SetPassword" , should it be RSPCONFIG_SET_PASSWD?

whowutwut · 2017-11-27T20:50:20Z

xCAT-server/lib/xcat/plugins/openbmc.pm

@@ -2477,9 +2503,20 @@ sub rspconfig_response {
        }
    }

+    if ($node_info{$node}{cur_status} eq "RSPCONFIG_PASSWD_VERIFY") {
+        if ($status_info{RSPCONFIG_PASSWD_VERIFY}{argv} ne $node_info{$node}{password}) {
+            xCAT::SvrUtils::sendmsg("Please input correct BMC password.", $callback, $node);


I always try to avoid using "Please" if possible.

Suggest: Current BMC password is incorrect, cannot set the new password.

whowutwut · 2017-11-27T20:53:52Z

xCAT-server/lib/xcat/plugins/openbmc.pm

    if ($node_info{$node}{cur_status} eq "RSPCONFIG_SET_RESPONSE") {
        if ($response_info->{'message'} eq $::RESPONSE_OK) {
-            xCAT::SvrUtils::sendmsg("BMC Setting Hostname...", $callback, $node);
+            if (defined $status_info{RSPCONFIG_SET_RESPONSE}{argv} and $status_info{RSPCONFIG_SET_RESPONSE}{argv} eq "password") {


Could we auto generate this message based on the {argv} passed in? If it's hostname or password. The danger here is if we get into this call with something else as argv... not hostname or password... it will always print Setting Hostname and we won't know what value was passed in.

But if we take argv and run it though ucfirst we can automatically generate the msg.

xuweibj · 2017-11-28T06:37:14Z

@whowutwut Yes, it's enabled. The output in the description is my UT result.

whowutwut · 2017-11-28T18:59:18Z

@xuweibj What I meant for the UT is to create automation UT cases. I'd like the developers to start creating these instead of relying on FVT team to handle all the burden. On each FW update that we get, we have to have a regression suite to make sure we didn't regress.. (As seen in #4378) and things are working OK. Manually running it cannot be the solution. If you can create PR to include the UT and associate it with #4196, that would be great!

whowutwut

I am OK with these changes.

rspconfig admin_password for OpenBMC

8a73d3b

xuweibj added the component:openbmc label Nov 24, 2017

xuweibj added this to the 2.13.9 milestone Nov 24, 2017

xuweibj requested a review from whowutwut November 24, 2017 08:26

whowutwut requested changes Nov 27, 2017

View reviewed changes

modified depending on comments

8d4d18b

xuweibj force-pushed the T4196 branch from 60c1cf1 to 8d4d18b Compare November 28, 2017 03:34

xuweibj added 2 commits November 28, 2017 12:22

Merge branch 'master' into T4196

241019d

Merge branch 'master' into T4196

aaf3c0f

xuweibj force-pushed the T4196 branch 2 times, most recently from 927cbce to aaf3c0f Compare November 28, 2017 06:32

whowutwut approved these changes Nov 28, 2017

View reviewed changes

whowutwut merged commit 4fcd15c into xcat2:master Nov 28, 2017

xuweibj deleted the T4196 branch November 29, 2017 00:39

gurevichmark mentioned this pull request Nov 7, 2018

rspconfig admin_passwd does not update xCAT DB tables #5775

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rspconfig admin_password for OpenBMC #4371

rspconfig admin_password for OpenBMC #4371

xuweibj commented Nov 24, 2017 •

edited

Loading

xcatbot commented Nov 24, 2017 •

edited

Loading

whowutwut commented Nov 27, 2017

whowutwut Nov 27, 2017

whowutwut Nov 27, 2017

whowutwut Nov 27, 2017

xuweibj commented Nov 28, 2017

whowutwut commented Nov 28, 2017 •

edited

Loading

whowutwut left a comment

rspconfig admin_password for OpenBMC #4371

rspconfig admin_password for OpenBMC #4371

Conversation

xuweibj commented Nov 24, 2017 • edited Loading

xcatbot commented Nov 24, 2017 • edited Loading

whowutwut commented Nov 27, 2017

whowutwut Nov 27, 2017

Choose a reason for hiding this comment

whowutwut Nov 27, 2017

Choose a reason for hiding this comment

whowutwut Nov 27, 2017

Choose a reason for hiding this comment

xuweibj commented Nov 28, 2017

whowutwut commented Nov 28, 2017 • edited Loading

whowutwut left a comment

Choose a reason for hiding this comment

xuweibj commented Nov 24, 2017 •

edited

Loading

xcatbot commented Nov 24, 2017 •

edited

Loading

whowutwut commented Nov 28, 2017 •

edited

Loading