Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspconfig setting hostname broken for last 2 day (PR #4326) #4378

Closed
whowutwut opened this issue Nov 27, 2017 · 3 comments
Closed

rspconfig setting hostname broken for last 2 day (PR #4326) #4378

whowutwut opened this issue Nov 27, 2017 · 3 comments

Comments

@whowutwut
Copy link
Member

Running my UT autoamtion, I find that setting hostname is broken, caused by #4326.....

------START::rspconfig_set_hostname::Time:Mon Nov 27 09:47:00 2017------

RUN:rspconfig mid05tor12cn16 hostname=mid05tor12cn16-UTset [Mon Nov 27 09:47:00 2017]
ElapsedTime:1 sec
RETURN rc = 1
OUTPUT:
mid05tor12cn16: Error: AttributeError("Attribute 'parameter_list' not defined.",)
Mon Nov 27 09:47:01 2017 mid05tor12cn16: [openbmc_debug] curl -k -c cjar -H "Content-Type: application/json" -d '{ "data": ["root", "xxxxxx"] }' https://172.11.139.16/login
Mon Nov 27 09:47:01 2017 mid05tor12cn16: [openbmc_debug] login_response 200 OK
Mon Nov 27 09:47:01 2017 mid05tor12cn16: [openbmc_debug] curl -k -b cjar -X PUT -H "Content-Type: application/json" -d '{"data":"mid05tor12cn16-UTset"}' https://172.11.139.16/xyz/openbmc_project/network
Mon Nov 27 09:47:01 2017 mid05tor12cn16: [openbmc_debug] rspconfig_set_response 500 Internal Server Error
CHECK:rc == 0	[Failed]

------END::rspconfig_set_hostname::Failed::Time:Mon Nov 27 09:47:01 2017 ::Duration::1 sec------

It looks like the endpoint got deleted in the last code changes to rspconfig... ..

The UT scripts work and show the correct HostName endpoint.

[root@briggs01 Network]# ./set_hostname.sh f6u18-bmc
++ date
Mon Nov 27 09:25:29 EST 2017
++ curl -c cjar -b cjar -k -H 'Content-Type: application/json' -X PUT -d '{"data": "f6u18-bmc" }' https://mid05tor12cn18-bmc//xyz/openbmc_project/network/config/attr/HostName
{
  "data": null,
  "message": "200 OK",
  "status": "ok"
}
@whowutwut
Copy link
Member Author

whowutwut commented Nov 27, 2017

Automation UT Testcases added with #4379

@gurevichmark
Copy link
Contributor

Fixed by PR #4380
Seems that #4326 removed the url path for hostname setting of /config/attr/HostName

@whowutwut
Copy link
Member Author

Closing this issue out, if we do not see it occur on automation #4370, then should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment