Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix py3.6 CI #234

Merged
merged 7 commits into from
Jan 7, 2021
Merged

Fix py3.6 CI #234

merged 7 commits into from
Jan 7, 2021

Conversation

raybellwaves
Copy link
Member

@raybellwaves raybellwaves commented Jan 6, 2021 •
edited
Loading

@raybellwaves raybellwaves marked this pull request as draft January 6, 2021 22:09
@raybellwaves raybellwaves mentioned this pull request Jan 6, 2021
Closed
@raybellwaves raybellwaves changed the title TEST CI Fix py3.6 CI Jan 7, 2021
@raybellwaves raybellwaves marked this pull request as ready for review January 7, 2021 17:10
@raybellwaves
Copy link
Member Author

Thanks @andersy005. @aaronspring I believe you were trying something similar. This should be good to merge once the CI finishes

@raybellwaves raybellwaves marked this pull request as draft January 7, 2021 17:13
@raybellwaves raybellwaves marked this pull request as ready for review January 7, 2021 17:15
@aaronspring
Copy link
Collaborator

I tried the older version...

@aaronspring aaronspring self-requested a review January 7, 2021 17:52
@aaronspring aaronspring merged commit ef46406 into xarray-contrib:master Jan 7, 2021
@andersy005
Copy link
Member

You're welcome, @raybellwaves

@raybellwaves raybellwaves mentioned this pull request Jan 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronspring aaronspring aaronspring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raybellwaves @aaronspring @andersy005