-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test raise if compute #224
Conversation
@@ -51,8 +77,9 @@ def test_skipna_returns_same_value_as_dropped_pairwise_nans(a_1d_nan, b_1d_nan, | |||
"""Tests that DataArrays with pairwise nans return the same result | |||
as the same two with those nans dropped.""" | |||
a_dropped, b_dropped, _ = drop_nans(a_1d_nan, b_1d_nan) | |||
res_with_nans = metric(a_1d_nan, b_1d_nan, "time", skipna=True) | |||
res_dropped_nans = metric(a_dropped, b_dropped, "time") | |||
with raise_if_dask_computes(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats a nice one. could be implemented allover the package
# return a dummy context manager so | ||
# that this can be used for non-dask objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm being nit-picky, you should change this to a """
docstring for style.
Looks like some trailing whitespace issues from |
Same here. What’s the status? |
Not sure what this means
|
Some listing thing. I usually just git add and pre-commit again |
@@ -46,3 +46,4 @@ | |||
~Contingency.observation_category_edges | |||
~Contingency.observations | |||
~Contingency.table | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line. Probably git added this by mistake
Think you need to rebase again to pick up #234 for example |
I don't think so; when I pull and push it says everything up to date... |
Sorry for the testing here. Looks like I finally got it on the last one. Probably still best if you merge my PR ahuang11#1 |
Feel free to do whichever. |
I thought I could merge PR in your repo but I can't. I think I can push to the branch though |
Thanks @ahuang11 |
#218
I moved the check for negative values in weights under np apply_ufunc