Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

[utilities.cake] Only look for namespaces in "obj" assemblies. #766

Merged
merged 1 commit into from
May 3, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented May 2, 2023

Context: dotnet/android-libraries#722

For some reason, 0.2.0-alpha4 of Xamarin.Legacy.Sdk causes package dependencies to be placed in the /bin directory whereas previously they were not. Our published namespace script looks for all .dll's in the /generated directory, which previously did not include dependencies. This resulted in adding namespaces that were in dependencies and not just the assemblies packaged in this repository.

To fix this, we can restrict ourselves to looking for assemblies in the /obj directory, which does not contain dependency assemblies.

@jpobst jpobst marked this pull request as ready for review May 2, 2023 21:18
@jpobst
Copy link
Contributor Author

jpobst commented May 2, 2023

Mac is broken on main, so this should be considered "green". 😁

@jpobst jpobst requested a review from moljac May 2, 2023 22:31
@jpobst jpobst merged commit d5818c3 into main May 3, 2023
@jpobst jpobst deleted the no-obj-namespaces branch May 3, 2023 03:50
@moljac
Copy link
Member

moljac commented May 3, 2023

Mac is broken on main, so this should be considered "green". 😁

Finally reproducible on CI. Thanks.

seems like

#addin nuget:?package=HolisticWare.Xamarin.Tools.ComponentGovernance&version=0.0.1.2

transitively pulls in some older packages.

Interesting: the same code works in AX without any problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants