Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utilities.cake] Only look for namespaces in "obj" assemblies. #722

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Apr 17, 2023

For some reason, 0.2.0-alpha4 of Xamarin.Legacy.Sdk causes package dependencies to be placed in the /bin directory whereas previously they were not. Our published namespace script looks for all .dll's in the /generated directory, which previously did not include dependencies. This resulted in adding namespaces that were in dependencies and not just the assemblies packaged in this repository.

To fix this, we can restrict ourselves to looking for assemblies in the /obj directory, which does not contain dependency assemblies.

@jpobst jpobst requested a review from moljac April 17, 2023 22:44
@jpobst jpobst marked this pull request as ready for review April 17, 2023 22:44
@jpobst jpobst merged commit 3732dc7 into main Apr 24, 2023
@jpobst jpobst deleted the no-obj-namespaces branch April 24, 2023 15:09
jpobst added a commit to xamarin/GooglePlayServicesComponents that referenced this pull request May 3, 2023
Context: dotnet/android-libraries#722

For some reason, `0.2.0-alpha4` of `Xamarin.Legacy.Sdk` causes package dependencies to be placed in the `/bin` directory whereas previously they were not.  Our published namespace script looks for all `.dll`'s in the `/generated` directory, which previously did not include dependencies.  This resulted in adding namespaces that were in dependencies and not just the assemblies packaged in this repository.

To fix this, we can restrict ourselves to looking for assemblies in the `/obj` directory, which does not contain dependency assemblies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants