Sequencing response format #447
Conversation
…logstore_xapi into quiz-strip-html
|
@ryansmith94 this is ready to review |
| $correctresponsepattern = implode ('[,]', $selections); | ||
| break; | ||
| default: | ||
| $correctresponsepattern = utils\get_string_html_removed($questionattempt->rightanswer); |
There was a problem hiding this comment.
Do choices also need to be imploded in the same way?
There was a problem hiding this comment.
I'm not sure, but I don't think so because I think the multi-choice question is only one option.
That would be out of scope for this PR anyway. The goal here is to preserve the behavior of the multi-choice question while changing the gap select one.
There was a problem hiding this comment.
I think it's ok to do this for multichoice too because this is also an issue for multichoiceset questions.
There was a problem hiding this comment.
Ok, since you insist, I fixed for multichoice questions where there are multiple correct answers too. :-)
Waiting for tests to run....
There was a problem hiding this comment.
Haha okay thanks Andrew 👍 looks good
…oko/moodle-logstore_xapi into sequencing-response-format
|
🎉 This PR is included in version 4.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Adds response and options information to gap select type questions.
Note this also includes PR #446 because I was worried about conflicts if I used two separate branches both forked from master.
Related Issues
Fixes #440
PR Type